[Pkg-clamav-devel] redo debian/rules with less dh for clamav

[Scott Kitterman]

On Wednesday, March 19, 2014 01:08:48 Andreas Cadhalpun wrote:
> Hi Sebastian,
> 
> On 18.03.2014 21:44, Sebastian Andrzej Siewior wrote:
> > I just pushed to
> > 
> >    alioth.debian.org/git/pkg-clamav/clamav.git bigeasy_debhelper
> > 
> > my debhelper rework. --stat says
> 
> Thanks for working on this.
> 
> > It is not done yet. It builds however. I need to add back the fix for
> > #621206, consider pkgdatadir and I think that was all.
> 
> I added the command to remove the dependency_libs to override_dh_strip,
> but I'm wondering, if we could just not include the .la file. Is it
> still needed, e.g. for reverse dependencies?
> 
> Some more comments:
> 
> I don't know, what you intend with pkgdatadir.
> And why is '.PHONY: override_dh_strip' necessary?
> 
> Since you rewrote the debian/rules, I think the copyright for 'Sample
> debian/rules' could/should be removed.
> 
> I enhanced the rules file a bit:
>   * Add some comments.
>   * Introduce the $CONFIG variable containing the configure flags
>     (improves readability).
>   * There are three configure options that I didn't find in the
>     configure script. What do these do?
>      - --disable-clamuko
>      - --with-system-tommath
>      - --without-included-ltdl
>   * Change '$(MAKE) check' to dh_auto_test.
>   * dh_auto_test automatically disables the test when cross-compiling and
>     handles nocheck, so the extra check is not needed.
>   * override_dh_auto_clean: run debconf-updatepo
>   * Split dh_auto_build in arch-dependent (-a) and -independent (-i).
>   * override_dh_installinit: clamav-freshclam needs --noscripts
>   * override_dh_installchangelogs: Install the upstream changelog
>   * override_dh_compress: Don't compress the example configuration file.
>   * Update the doc-base file, because PDFs get compressed now.
>   * Create static debian/clean instead of creating it in every build
>     (because it doesn't get removed by debian/clean).
>   * Make the bug script executable.
> 
> I think the result is now quite equivalent to the old rules file.

Thanks.  Clamav is a VERY old package and I've not had time to work on 
modernization.  It is, however, essential that we maintain supportability on 
oldstable, so please make sure your changes work with the tools there (I 
didn't check).

On a related note, I've uploaded 6debu3 and 7debu3 for oldstable and stable 
and they should get accepted tonight.

Scott K