[Pkg-clamav-devel] redo debian/rules with less dh for clamav

[Andreas Cadhalpun]

Hi,

On 19.03.2014 20:57, Sebastian Andrzej Siewior wrote:
> On 2014-03-19 01:08:48 [+0100], Andreas Cadhalpun wrote:
>> I added the command to remove the dependency_libs to override_dh_strip, but
>> I'm wondering, if we could just not include the .la file. Is it still
>> needed, e.g. for reverse dependencies?

I removed the .la file now.

>> I don't know, what you intend with pkgdatadir.

I removed the pkgdatadir, as it seems to have no effect.

>> And why is '.PHONY: override_dh_strip' necessary?
>
> https://wiki.debian.org/DebugPackage says so.

Interesting... but unfortunately that page doesn't give an explanation.
It's probably correct to have it, but I would like to know why.

>> Since you rewrote the debian/rules, I think the copyright for 'Sample
>> debian/rules' could/should be removed.
> Okay.

Thus I removed that copyright notice.

>>   * There are three configure options that I didn't find in the
>>     configure script. What do these do?
>>      - --disable-clamuko
>>      - --with-system-tommath
>>      - --without-included-ltdl
>
> I should have taken it from the old rules i.e. left that line unchanged.
> I was going to review them while swiching to dh_configure (or something
> similar I don't recall right now).

The disable-clamuko is removed now and I added a comment about the others.

>>   * override_dh_installchangelogs: Install the upstream changelog
>
> So you install upstream changelog file in every package. Wouldn't one
> copy be enough?

Maybe, but the Debian changelog is also installed in every package. 
(Besides, if the ChangeLog had a more widely used name (changelog), 
dh_installchangelog would install it automatically.)

>>   * Create static debian/clean instead of creating it in every build
>>     (because it doesn't get removed by debian/clean).
> makes sense .)

The templates shouldn't always get cleaned, so I removed them from the 
clean file again.

>>   * Make the bug script executable.
>
> I could swear that this happend somehow in the background.

It didn't happen, when I built the package.

>> I think the result is now quite equivalent to the old rules file.
>
> boah. That makes my todo  list a little smaller. Thanks.

Is there still something todo for the new debian/rules?

Best regards,
Andreas