[Pkg-clamav-devel] redo debian/rules with less dh for clamav

[Scott Kitterman]

On March 20, 2014 6:20:53 PM EDT, Sebastian Andrzej Siewior <sebastian at breakpoint.cc> wrote:
>On 2014-03-20 13:51:03 [+0100], Andreas Cadhalpun wrote:
>> Hi,
>Hi,
>
>> >>And why is '.PHONY: override_dh_strip' necessary?
>> >
>> >https://wiki.debian.org/DebugPackage says so.
>> 
>> Interesting... but unfortunately that page doesn't give an
>explanation.
>> It's probably correct to have it, but I would like to know why.
>> 
>
>A phony target is a hint that this rules does not build a file. None of
>the dh rules do this so actually each one of them should be phony. The
>info page of make says it is good for performance. Well. bah. I think
>we
>can live without that one.
>
>> Is there still something todo for the new debian/rules?
>
>If rebuilt it on wheezy with new & old files:
>--- old_rules/files.txt	2014-03-20 22:30:38.961220037 +0100
>+++ new_rules/files.txt	2014-03-20 22:32:00.845218824 +0100
>@@ -110,9 +110,9 @@
> ./clamav-docs/usr/share/doc/clamav-docs/BUGS
> ./clamav-docs/usr/share/doc/clamav-docs/changelog.Debian.gz
> ./clamav-docs/usr/share/doc/clamav-docs/changelog.gz
>-./clamav-docs/usr/share/doc/clamav-docs/clamav-mirror-howto.pdf
>+./clamav-docs/usr/share/doc/clamav-docs/clamav-mirror-howto.pdf.gz
> ./clamav-docs/usr/share/doc/clamav-docs/clamav-mirror-howto.tex.gz
>-./clamav-docs/usr/share/doc/clamav-docs/clamdoc.pdf
>+./clamav-docs/usr/share/doc/clamav-docs/clamdoc.pdf.gz
> ./clamav-docs/usr/share/doc/clamav-docs/clamdoc.tex.gz
> ./clamav-docs/usr/share/doc/clamav-docs/clam.eps.gz
> ./clamav-docs/usr/share/doc/clamav-docs/copyright
>@@ -207,7 +207,7 @@
> ./clamav-docs/usr/share/doc/clamav-docs/NEWS.Debian.gz
> ./clamav-docs/usr/share/doc/clamav-docs/README.Debian.gz
> ./clamav-docs/usr/share/doc/clamav-docs/README.gz
>-./clamav-docs/usr/share/doc/clamav-docs/signatures.pdf
>+./clamav-docs/usr/share/doc/clamav-docs/signatures.pdf.gz
> ./clamav-docs/usr/share/doc/clamav-docs/signatures.tex.gz
> ./clamav-freshclam
> ./clamav-freshclam_0.98.1+dfsg-5_amd64.deb
>@@ -418,7 +418,6 @@
> ./libclamav-dev/usr/include
> ./libclamav-dev/usr/include/clamav.h
> ./libclamav-dev/usr/lib
>-./libclamav-dev/usr/lib/libclamav.la
> ./libclamav-dev/usr/lib/libclamav.so
> ./libclamav-dev/usr/lib/pkgconfig
> ./libclamav-dev/usr/lib/pkgconfig/libclamav.pc
>
>that means a few pdf are now compressed. Is this bad?

Yes. Please fix.

>The removal of the .la file:
>That one is used by libtool and libltdl. I just built
>c-icap-modules_0.1.6-1, dansguardian_2.10.1.1-5, havp_0.92a-2 and
>python-clamav_0.4.1-7 because they all build-depend on libclamav6. They
>all built fine.
>The other problem might be if someone tries to staticly link against
>libclamav. This is not the case right now (not for the four packages I
>just mentioned).
>So I would say, that I am fine with dropping that file.

Static linking isn't supported by Debian, so I'm not worried about it. 

Scott K