[Pkg-clamav-devel] redo debian/rules with less dh for clamav

[Andreas Cadhalpun]

Hi,

On 20.03.2014 20:21, Sebastian Andrzej Siewior wrote:
> On 2014-03-20 13:51:03 [+0100], Andreas Cadhalpun wrote:
>>>> I don't know, what you intend with pkgdatadir.
>>
>> I removed the pkgdatadir, as it seems to have no effect.
>
> It has. The last time I looked it sets the default directory where the
> rules are saved which lands only in config file. There is a configure
> option for that.

I can't find a difference between the packages build with pkgdatadir to 
those without this. Can you point me to a difference?

>>>> And why is '.PHONY: override_dh_strip' necessary?
>>>
>>> https://wiki.debian.org/DebugPackage says so.
>>
>> Interesting... but unfortunately that page doesn't give an explanation.
>> It's probably correct to have it, but I would like to know why.
>
> A phony target is a hint that this rules does not build a file. None of
> the dh rules do this so actually each one of them should be phony. The
> info page of make says it is good for performance. Well. bah. I think we
> can live without that one.

So all override* targets should be phony to (marginally) improve 
performance?
I'm not sure that's worth the additional lines in debian/rules.

>>>>   * Create static debian/clean instead of creating it in every build
>>>>     (because it doesn't get removed by debian/clean).
>>> makes sense .)
>>
>> The templates shouldn't always get cleaned, so I removed them from the clean
>> file again.
>
> Why not?

Because they are only created, when PO2DEBCONF is yes, which it normally 
is not. (I actually don't know, when this will be yes.)

>>>> I think the result is now quite equivalent to the old rules file.
>>>
>>> boah. That makes my todo  list a little smaller. Thanks.
>>
>> Is there still something todo for the new debian/rules?
>
> Basically you are too fast for me now :) So let me look at the latest
> thing we have now, test is somehow and then I get back to you.

The PDFs are excluded from compression now and I added a symbols file 
for libclamav.

I build with the old rules file (with added faketime) and compared the 
result to the packages build with the new rules file. I didn't find any 
fundamental difference, only:
  * DEBIAN/control reads now 'libclamav6 (>= 0.98.1)' instead of 
'libclamav6 (>= 0.98.1+dfsg)', thanks to the symbols file.
  * A few bytes in the binaries differ and I can't figure out why.

Thus I think we can switch to the new debian/rules, assuming it still 
builds in oldstable/stable.

Best regards,
Andreas