[Pkg-clamav-devel] Bug#783720: clamav-daemon does not honour Local* with systemd

[Andreas Cadhalpun]

Control: tags -1 pending

Hi Sebastian,

On 29.04.2015 21:09, Andreas Cadhalpun wrote:
> On 29.04.2015 14:56, Sebastian Andrzej Siewior wrote:
>> The options
>> 	LocalSocket /var/run/clamav/clamd.ctl.change
>> 	LocalSocketGroup nobody
>> 	LocalSocketMode 600
>>
>> in clamd.conf are not considered when used via systemd. It seems that 
>> 	/lib/systemd/system/clamav-daemon.socket
>> has those options hardcoded. Not sure if this should be updated by
>> debconf or the clamd.conf should win over the service file but the way
>> it is now the options are silently ignored which means a regression from
>> Wheezy.
> 
> This should be handled just as the TCPSocket option via extending the
> socket unit with /etc/systemd/system/clamav/extend.conf.
> (I should have noticed this, when implementing the TCPSocket extending.)
> I'll work on implementing that shortly.

I just pushed a fix for this.
It seems to work as intended, but additional testing would be nice. ;)

I've also run this through piuparts, which didn't complain.

However while testing this, I noticed another issue:
The clamav-daemon.socket is not stopped during 'dpkg-reconfigure clamav-daemon'.
Thus after changing the name of the socket, a stale socket file is left behind.
I'm not sure if that's really a problem worth fixing though. Thoughts?

Best regards,
Andreas