[Pkg-clamav-devel] tomfastmath is ready

[Sebastian Andrzej Siewior]

On 2015-02-06 20:56:24 [+0100], Andreas Cadhalpun wrote:
> Hi Sebastian,
Hi Andreas,

> There are also some other tomfastmath changes in clamav.
> In the upstream git repo one finds:
finally I'm done with it.

> $ git log libclamav/tomsfastmath libclamav/bignum_fast.h
> commit b9b09d7fb06f2b31bf825bc1e1eb8a162d7c5a25
> Author: Steven Morgan <smorgan at sourcefire.com>
> Date:   Mon Nov 3 16:34:26 2014 -0500
> 
>     bb11166 - fix incorrect length in strncat() call.
applied.

> commit cd94be7a52a8b62155ff6e78fdb8e1b921c73d66
> Author: Shawn Webb <swebb at sourcefire.com>
> Date:   Thu Jul 10 18:11:49 2014 -0400
> 
>     Silence a bunch of compiler warnings in libclamav

did something else

> commit a9d40672390a82e91a8d5c21ee2fe172fca4d2f8
> Author: David Raynor <draynor at sourcefire.com>
> Date:   Wed Oct 2 15:00:23 2013 -0400
> 
>     bb #9017: tomsfastmath warning with zLinux on s390x
did something else

> 
> commit c424c9301376091282cf64df7eae8629682c140a
> Author: David Raynor <draynor at sourcefire.com>
> Date:   Wed Feb 13 15:35:01 2013 -0500
> 
>     cid #11125/#11126 fixed
> 
> commit 627e8835f113cbad18afc0773c4b6e91f5826f20
> Author: David Raynor <draynor at sourcefire.com>
> Date:   Wed Feb 13 15:10:41 2013 -0500
> 
>     cid #11125/#11126

those two are not bug ids but someting from an auto-testing tool. It
does not make sense.

> commit 7dfcf6e2df660a9183e89a4fb1bb0daaa3948dc4
> Author: David Raynor <draynor at sourcefire.com>
> Date:   Fri Feb 1 17:05:53 2013 -0500
> 
>     bb #6671: tweak asm register reference in tomsfastmath code for clang
> compatibility

took upstream's version

> commit 429771f8d9eb2c3b839d03f5e0ba05bc9e021ee9
> Author: David Raynor <draynor at sourcefire.com>
> Date:   Tue Aug 28 13:37:48 2012 -0400
> 
>     bb#5700: implement and use fp_toradix_n()
took upstream's version

> 
> commit 3afedd076111096e150443ed8a4172452de828e2
> Author: Török Edvin <edwin at clamav.net>
> Date:   Wed May 30 13:37:32 2012 +0300
> 
>     fix GCC warnings.

did something else

>     especially the one about gzFile vs gzFile*, gzopen returns gzFile!
> 
> commit 540aece0979ec37392c24687170b7121c0f753e2
> Author: Török Edvin <edwin at clamav.net>
> Date:   Thu Jan 19 09:06:51 2012 +0200
> 
>     bb #4168

ignored. It built on i386 without a problem and the gcc bug in ia64
might have been fixed in the meantime.

> Can you forward these fixes to tomsfastmath upstream as well?

I forwarded what made sense upstream. I backported around 20 patches
from upstream. It compiles without warnings on amd64 and that one
warning in fp_ident on i386 is minor. I will look at it later.
There is one patch which I need mail upstream. I compiled clamav on i386
against it and the testsuite passes. Haven't look at the build log yet.

I defined four symbols optional which are only exported on 32bit
architectures. The longterm plan to fix this properly is to wait for
dpkg 1.18 which defines the tag arch-bits= or to ask upstream those
symbols are worth exporting or should remain for internal usage. I tend
to the later.

> Best regards,
> Andreas

Sebastian