[Pkg-clamav-devel] tomfastmath is ready (take 2)

Andreas Cadhalpun andreas.cadhalpun at gmail.com
Thu Nov 12 21:06:02 UTC 2015


Hi Sebastian,

On 12.11.2015 21:33, Sebastian Andrzej Siewior wrote:
> It is tricky. tomcrypt has a tfm layer where it can be be compiled
> against tomfastmath instead of tommath. This one casts the const away [0].
> There is a similar function in tommath called mp_read_radix() which is
> const [1].

Ah, that explains where the const is coming from.

> wolfcrypt is the only package that codesearch.d.n found that uses the
> function as const. It seems they used tommath in the past and made then
> a layer which now invokes tomfastmath in the background and therefore they
> kept the const [2].

Thanks for checking this.

> I will try to address that header change upstream but I doubt there will
> be a new release just with this change :)

Yes, that's unlikely.

> So I would say it is up to you
> whether we should ship that patch in tfm or not. I'm fine both ways.

Considering that tommath uses const in the equivalent function and that
tomsfastmath is supposed to be a replacement of it, I think it makes
more sense to patch tfm to use const, too.

Best regards,
Andreas



More information about the Pkg-clamav-devel mailing list