[Pkg-clamav-devel] tomfastmath is ready

[Scott Kitterman]

On Tuesday, April 07, 2015 11:42:26 PM Sebastian Andrzej Siewior wrote:
> On 2015-04-01 17:00:33 [-0400], Scott Kitterman wrote:
> > > > so upstream asked if we could do the symbol hiding within our debian/
> > > > folder. Doesn't look that bad, does it?
> > > 
> > > I don't think it's a good idea to perpetually deviate from upstream's
> > > ABI/API, because then projects might start using some of this low level
> > > stuff and not work in Debian.
> > > 
> > > Does upstream think this low level stuff could be useful outside of
> > > tomsfastmath or where does the reluctance to hide these symbols come
> > > from?
> > 
> > I think it would be good to get all this sorted out before we upload to
> > the
> > Debian archive.  I definitely don't want to have a Debian specific ABI
> > break after it's in the archive.
> 
> Okay. So I forwaded these statements from you two. I don't remeber the
> exact answer anymore but I think he got convinced to take those in.
> I will try to get some more informations on when those patches show up
> in the repository or even a release so there is more than just me
> writing something here :)

I finally had time to look at tomsfastmath again.  A couple of points:

1.  patches/tfm-make-a-few-functions-static.patch changes the ABI, doesn't it?  
Did upstream agree to do this, but just haven't released it yet or is this 
still an open question for upstream?

2.  Public domain is problematic in many jurisdictions, Germany and the United 
States being two.  That's why he's got WFPL in the LICENSE file as well.  
Please include that in debian/copyright and then adjust the package 
description (may just say 'very liberally licensed' if you feel that's an 
important point).

Other than that, I'd upload it now.

Scott K

P.S.  Sorry for the delay.