[Pkg-clamav-devel] Change to fix-ssize_t-size_t-off_t-printf-modifier.patch
Sebastian Andrzej Siewior
sebastian at breakpoint.cc
Mon Feb 15 20:15:02 UTC 2016
On 2016-02-15 17:29:15 [+0100], Louis Bouchard wrote:
> In 0007-fix-ssize_t-size_t-off_t-printf-modifier.patch, the patch on
> sigtool/sigtool.c had the following cast : (unsigned long)strlen
>
> > + mprintf("Signature received (length = %" _sizet ")\n",
> > + (unsigned long)strlen(buff) - 10);
>
> That cast has disapeared from the renamed patch
> fix-ssize_t-size_t-off_t-printf-modifier.patch :
>
> > + mprintf("Signature received (length = %" _sizet ")\n",
> > + strlen(buff) - 10);
>
> Was this removal intentional ? If not, I would be happy to file a bug for this
> including a refresh of the patch since I intend to add it an an Ubuntu delta.
>
> If better otherwise, I'll drop that delta on my side.
strlen() returns size_t and the size-modifier _sizet is for size_t so there
is no need for a type cast here. There should also be no warning here at
compile time.
> TIA,
>
> Kind regards,
>
> ...Louis
Sebastian
More information about the Pkg-clamav-devel
mailing list