[Pkg-clamav-devel] Patch to extend systemd socket support to more than two sockets

[Matthias Hörmann]

Hello

It must be weird that I am replying to a mail that is almost two years old but I must have missed your reply back then and only now
found it again when the topic of upstream inclusion of this came up again after my latest rebase of the patch for the new version of
clamav in jessie a few days ago.

The problem very much did not disappear with the changes you did back then and in fact we have had to maintain
our own patches for jessie and stretch to make use of multiple TCP sockets since then.

The patches we do are about the support for systemd to hand listen sockets to clamav-daemon on startup, not about socket activation
per se, though I suppose that ability is necessary for socket activation to work.

The current version of the patches can be found here for jessie and stretch (just rebased to make line numbers fit, no major differences)

https://github.com/taladar/clamav/blob/master/debian/patches/0014-allow-multiple-tcp-sockets-in-socket-activation.patch (jessie)
https://github.com/taladar/clamav/blob/saltation_patches_stretch/debian/patches/ff14-allow-multiple-tcp-sockets-in-socket-activation.patch (stretch)

It would be great if we could get this included in the official Debian package. If you need any more information please ask.

Again, I am sorry for overlooking your response back then.

fon: +49 (0) 521 - 329647-29
fax: +49 (0) 521 - 329647-40
email: matthias.hoermann at saltation.com


---------------
saltation GmbH & Co. KG | Niederwall 43 | 33602 Bielefeld
Sitz Bielefeld | Amtsgericht Bielefeld HRA 15344
Persönlich haftende Gesellschafterin:
saltation Beteiligungs-GmbH | Niederwall 43 | 33602 Bielefeld
Sitz Bielefeld | Amtsgericht Bielefeld HRB 39339
Geschäftsführer: Daniel Brün
---------------

________________________________________
From: Sebastian Andrzej Siewior <sebastian at breakpoint.cc>
Sent: Tuesday, September 20, 2016 9:42:52 PM
To: Matthias Hörmann
Cc: pkg-clamav-devel at lists.alioth.debian.org
Subject: Re: [Pkg-clamav-devel] Patch to extend systemd socket support to more than two sockets

On 2016-09-19 11:06:35 [+0200], Matthias Hörmann wrote:
> Hello
Hi,

> The current Debian jessie version of clamav does not allow systemd
> to pass more than two sockets (one UDS, one TCP) to the clamav daemon.
>
> This prevents us from binding explicitly to several IP:port combinations.
>
> We have been using the attached patch successfully in production for
> several versions to fix that issue but of course every new version of clamav
> breaks this again until we compile our own, patched version so I want to
> submit this patch for inclusion in the Debian patch series.

If you look at unstable (which is almost the same thing as jessie) you
will notice that I removed that socket support for systemd. The commits
are
 https://anonscm.debian.org/cgit/pkg-clamav/clamav.git/commit/?id=3bdb184f87270d6f5053b1382e1ab0637e9fd74c
 https://anonscm.debian.org/cgit/pkg-clamav/clamav.git/commit/?id=a4556736fe82424eab80d74f6ddca9c197d7321c
 https://anonscm.debian.org/cgit/pkg-clamav/clamav.git/commit/?id=bdc1ee5fa19278b8955520b7e6796d9ffd90a8ba

Would it be correct to assume that your problem goes away once this
change lands in jessie?

Sebastian