[Pkg-clamav-devel] Bug#1096439: clamsmtp: ftbfs with GCC-15

[Matthias Klose]

Package: src:clamsmtp
Version: 1.10-18
Severity: important
Tags: sid forky
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-15

[This bug is NOT targeted to the upcoming trixie release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-15/g++-15, but succeeds to build with gcc-14/g++-14. The
severity of this report will be raised before the forky release.

The full build log can be found at:
http://qa-logs.debian.net/2025/02/16/amd64exp/clamsmtp_1.10-18_unstable_gccexp.log.gz
The last lines of the build log are at the end of this report.

To build with GCC 15, either set CC=gcc-15 CXX=g++-15 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

GCC 15 now defaults to the C23/C++23 standards, exposing many FTBFS.
Other Common build failures are new warnings resulting in build failures
with -Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-15/porting_to.html

[...]
gcc -DHAVE_CONFIG_H -I. -I..   -Wdate-time -D_FORTIFY_SOURCE=2 -I../common/ -I../ -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/clamsmtp-1.10=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -I/usr/local/include  -D_POSIX_PTHREAD_SEMANTICS -c -o clamsmtpd-compat.o `test -f '../common/compat.c' || echo './'`../common/compat.c
NOTE: Ignore any warnings about mktemp(). It's used safely in this case.

../common/smtppass.c: In function ‘sp_run’:
../common/smtppass.c:249:9: error: expected identifier or ‘(’ before ‘true’
  249 |     int true = 1;
      |         ^~~~
../common/smtppass.c:307:5: warning: ‘siginterrupt’ is deprecated: Use sigaction with SA_RESTART instead [-Wdeprecated-declarations]
  307 |     siginterrupt(SIGINT, 1);
      |     ^~~~~~~~~~~~
In file included from /usr/include/x86_64-linux-gnu/sys/param.h:28,
                 from ../common/smtppass.c:46:
/usr/include/signal.h:324:12: note: declared here
  324 | extern int siginterrupt (int __sig, int __interrupt) __THROW
      |            ^~~~~~~~~~~~
../common/smtppass.c:308:5: warning: ‘siginterrupt’ is deprecated: Use sigaction with SA_RESTART instead [-Wdeprecated-declarations]
  308 |     siginterrupt(SIGTERM, 1);
      |     ^~~~~~~~~~~~
/usr/include/signal.h:324:12: note: declared here
  324 | extern int siginterrupt (int __sig, int __interrupt) __THROW
      |            ^~~~~~~~~~~~
../common/smtppass.c:319:56: error: lvalue required as unary ‘&’ operand
  319 |     setsockopt(sock, SOL_SOCKET, SO_REUSEADDR, (void *)&true, sizeof(true));
      |                                                        ^
../common/smtppass.c: In function ‘thread_main’:
../common/smtppass.c:690:5: warning: ‘siginterrupt’ is deprecated: Use sigaction with SA_RESTART instead [-Wdeprecated-declarations]
  690 |     siginterrupt(SIGINT, 1);
      |     ^~~~~~~~~~~~
/usr/include/signal.h:324:12: note: declared here
  324 | extern int siginterrupt (int __sig, int __interrupt) __THROW
      |            ^~~~~~~~~~~~
../common/smtppass.c:691:5: warning: ‘siginterrupt’ is deprecated: Use sigaction with SA_RESTART instead [-Wdeprecated-declarations]
  691 |     siginterrupt(SIGTERM, 1);
      |     ^~~~~~~~~~~~
/usr/include/signal.h:324:12: note: declared here
  324 | extern int siginterrupt (int __sig, int __interrupt) __THROW
      |            ^~~~~~~~~~~~
../common/smtppass.c:728:12: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
  728 |     return (void*)(ret == 0 ? 0 : 1);
      |            ^
../common/smtppass.c: In function ‘sp_setup_forked’:
../common/smtppass.c:1806:5: warning: ‘siginterrupt’ is deprecated: Use sigaction with SA_RESTART instead [-Wdeprecated-declarations]
 1806 |     siginterrupt(SIGINT, 0);
      |     ^~~~~~~~~~~~
/usr/include/signal.h:324:12: note: declared here
  324 | extern int siginterrupt (int __sig, int __interrupt) __THROW
      |            ^~~~~~~~~~~~
../common/smtppass.c:1807:5: warning: ‘siginterrupt’ is deprecated: Use sigaction with SA_RESTART instead [-Wdeprecated-declarations]
 1807 |     siginterrupt(SIGTERM, 0);
      |     ^~~~~~~~~~~~
/usr/include/signal.h:324:12: note: declared here
  324 | extern int siginterrupt (int __sig, int __interrupt) __THROW
      |            ^~~~~~~~~~~~
../common/smtppass.c: In function ‘connection_loop’:
../common/smtppass.c:538:21: warning: ignoring return value of ‘write’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  538 |                     write(fd, SMTP_STARTFAILED, KL(SMTP_STARTFAILED));
      |                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../common/smtppass.c:555:13: warning: ignoring return value of ‘write’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  555 |             write(fd, SMTP_STARTBUSY, KL(SMTP_STARTBUSY));
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
make[3]: *** [Makefile:434: clamsmtpd-smtppass.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[3]: Leaving directory '/build/reproducible-path/clamsmtp-1.10/src'
make[2]: *** [Makefile:375: all-recursive] Error 1
make[2]: Leaving directory '/build/reproducible-path/clamsmtp-1.10'
make[1]: *** [Makefile:316: all] Error 2
make[1]: Leaving directory '/build/reproducible-path/clamsmtp-1.10'
dh_auto_build: error: make -j8 returned exit code 2
make: *** [debian/rules:6: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2