scout

[Wolodja Wentland]

Hi Eugenio,

On Wed, May 22, 2013 at 18:37 +0200, Eugenio Cano-Manuel Mendoza wrote:
> I just pushed scout, fixed all the problems that we talked about. Please let
> me know if I missed anything.

Thank you very much for working on this. I just took a short look at your
package and a couple of things met the eye.

1. Please remove trailing whitespace

There are some files with trailing whitespace in them. At least debian/control
has it. It is typically a good idea to configure git to complain whenever you
try to commit files with trailing whitespace. To do that you rename the
pre-commit.sample git hook to pre-commit in the .git/hooks/ directory.

You can easily remove trailing whitespace in vim by running ":%s/\s\+$//" no
idea which editor you use, but probably provides similar functionality.

2. Run lintian on your packages

Debian provides a number of tools to check common errors in packages and one
of them is lintian. If I run lintian on the package you uploaded I get the
following output:

--- snip ---
$ lintian -IE --pedantic scout_0.1.0-1_amd64.changes
P: scout source: unversioned-copyright-format-uri http://dep.debian.net/deps/dep5/
I: scout source: debian-watch-file-is-missing
P: libscout-clojure: no-upstream-changelog
W: libscout-clojure: new-package-should-close-itp-bug
I: libscout-clojure: description-synopsis-might-not-be-phrased-properly
--- snip ---

You can pass the "-i" option to lintian to show additional information about
the problems in question. I configured git-buildpackage to run lintian
whenever I build a package. If you want it to do the same, edit your
~/.gbp.conf and, in particular, make sure that the following line is
uncommented:

    postbuild = lintian -iIE --pedantic $GBP_CHANGES_FILE

I would recommend to fix all those warnings/errors and ping us on IRC if you
run into problem with any of them.

That's it for now, thank you for your contribution and I am looking forward to
the next iteration.
-- 
Wolodja <debian at babilen5.org>

4096R/CAF14EFC
081C B7CD FF04 2BA9 94EA  36B2 8B7F 7D30 CAF1 4EFC
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-clojure-maintainers/attachments/20130523/1383c424/attachment.pgp>