[Pkg-cmake-team] Bug#948924: Bug#948924: cmake: FTBFS: test failure against libxslt 1.1.34

[Mattia Rizzolo]

Hi Felix,

thank you for the quick follow up

On Tue, Jan 14, 2020 at 10:29:26PM +0100, Felix Geyer wrote:
> > your package failed to rebuild in a sid/amd64 chroot against libslt 1.1.34.
> 
> The problem seems to be that cmake's FindLibXslt can't deal with the headers
> being split across /usr/include and /usr/include/<arch>.

Why do you say so?
That part hasn't change for many many years (since 2017! version
1.1.29-3), and in particular doesn't change between the version
currently in unstable and experimental:

% debdiff libxslt1-dev_1.1.32-2.2_amd64.deb libxslt1-dev_1.1.34-1_amd64.deb |grep -v doc
[The following lists of changes regard files as different if they have
different names, permissions or owners.]

Files in second .deb but not in first
-------------------------------------
lrwxrwxrwx  root/root   /usr/lib/x86_64-linux-gnu/libxslt.so -> libxslt.so.1.1.34

Files in first .deb but not in second
-------------------------------------
-rw-r--r--  root/root   /usr/lib/x86_64-linux-gnu/libexslt.a
-rw-r--r--  root/root   /usr/lib/x86_64-linux-gnu/libxslt.a
-rw-r--r--  root/root   /usr/share/man/man1/xslt-config.1.gz
-rwxr-xr-x  root/root   /usr/bin/xslt-config
lrwxrwxrwx  root/root   /usr/lib/x86_64-linux-gnu/libxslt.so -> libxslt.so.1.1.32


I forgot to mention indeed that besides dropping the xslt-config I also
dropped the static library, I hope that cmakes doesn't depend on it :)

> Would you consider moving all headers to /usr/include/<arch>? This should make
> libxslt's packaging easier and avoid special cases in build systems like cmake
> that try to detect it.

The fact that the single file xsltconfig.h is within the arch-specific
path indeed comes from the packaging and I could move it all; that said,
I can't imagine why cmake would even notice such thing.  Tring to
'#include <libxslt/xsltconfig.h>' ought to work regardless; if you are
depending and checking the specific location of header files that are
places in standard location, I deem to say that you are not doing
yourself any favour. :)

Could you perhaps point me toward the pieace of code in cmake that is
dealing with this, and what is failing?  Perhaps I'm able to help out a
bit.

-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
More about me:  https://mapreri.org                             : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-cmake-team/attachments/20200114/3219c94e/attachment.sig>