[Pkg-cmake-team] Bug#948924: Bug#948924: cmake: FTBFS: test failure against libxslt 1.1.34

[Mattia Rizzolo]

On Wed, Jan 15, 2020 at 12:21:23AM +0100, Felix Geyer wrote:
> > Could you perhaps point me toward the pieace of code in cmake that is
> > dealing with this, and what is failing?  Perhaps I'm able to help out a
> > bit.
> 
> The code is at https://salsa.debian.org/cmake-team/cmake/blob/master/Modules/FindLibXslt.cmake
> If pkg-config is installed it takes the version from there and everything
> should work fine.
> Otherwise it uses the path of libxslt/xslt.h and parses the version from
> xsltconfig.h in the same path. This fails as xsltconfig.h is in a different
> path. But as you pointed out this already fails with the package from unstable.
> 
> The problem is actually triggered by having libxslt1-dev installed in your
> build chroot. In a clean cmake package build libxslt1-dev is not installed
> and cmake just skips the tests that fails in your build.

Oh wow.
So it turns out that my attempt at hastening the rebuilds by
pre-installed the new binaries in the choort backfired here.

Having said that, reading that .cmake file is't not clear to me why it
would skip the test if libxslt1-dev is not installed.

> So we can
> a) ignore it (until the cmake build somehow pulls in libxslt)

I'd probably go for this and close this bug if you agree.

> b) make cmake build-depend on pkg-config

Your call.

> c) move all xslt headers into the same path

I'd rather avoid changing upstream's configuration even more.

There is also a d) have that .cmake file use find_path() also to detect
the path of libxslt/xsltconfig.h, instead of assuming it lives with
xslt.h.

-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
More about me:  https://mapreri.org                             : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-cmake-team/attachments/20200115/2e7d185e/attachment.sig>