[Pkg-crosswire-devel] RFS: bibledit/5.0.105-1 [NMU]

[Roberto C. Sánchez]

On Fri, Feb 24, 2017 at 12:23:07PM +0000, Teus Benschop wrote:
>    Hi Roberto,
>    The bibledit package that was uploaded to [1]mentors.debian.net had an
>    issue with a dependency on the external libmbedtls. It caused a
>    segmentation fault shortly after the initial calls to that library. I have
>    uploaded a new package with a fix for that issue. It is available
>    at [2]https://mentors.debian.net/debian/pool/main/b/bibledit/bibledit_5.0.107-1.dsc.
>    The git repository at [3]https://github.com/bibledit/debian was updated
>    too, and the newest tags are debian/5.0.107-1 and upstream/[4]5.0.107.
>    Sorry for any inconvenience this may cause to you.
>    Teus.

Hi Teus,

I am sorry for the long delay, but this somehow got buried in my inbox.

I have reviewed the updated package and I have some comments:

 1. The README.Debian contains no useful content and should be updated
 with something useful or removed.

 2. The override for the mbed library is not being used and should be
 removed (I: bibledit source: unused-override embedded-library), and
 instead the override should be applied to /usr/bin/bibledit, as that is
 what is causing lintian to complain (E: bibledit: embedded-library
 usr/bin/bibledit: mbedtls)

 3. Lintian complains that about the size /usr/share in the new package
 (I: bibledit: arch-dep-package-has-big-usr-share 170116kB 95%).  While
 this is only info-level, I think it should be addressed.  Specifically,
 the best course of action would be to introduce an arch-indep
 bibledit-data package similar to the old bibledit-gtk-data package.

If you could address these issues, I will review the updated package (in
a more timely fashion this time, I promise).

Regards,

-Roberto

-- 
Roberto C. Sánchez
http://people.connexer.com/~roberto
http://www.connexer.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-crosswire-devel/attachments/20170320/514c33b6/attachment.sig>