[pkg-crosswire-devel] Xiphos lookin' good

[Teus Benschop]

Hi Daniel,

I had intended to acknowledge the person who sent the patch, but then
forgot to do so... I can fix that in the new upload.

Yes, I had assumed that $ gbp would automatically include the source or
omit it, but this wasn't the case in this situation. Thanks for the hint
how to fix that.

The patch was separated into two patches because the original patch could
not be applied cleanly. Some chunks failed to be applied. So I manually did
the changes as listed in that original patch. And that led to the
additional and separate patches.

Regards,

Teus.

On Sat, 17 Nov 2018 at 17:28 Daniel Glassey <wdg at debian.org> wrote:

> Thanks Teus,
>
> I think it is a good idea to acknowledge people who send patches in the
> changelog entry where they are included.
>
> I'm not sure what happened it your build but it looks like you uploaded the
> orig source by mistake. It is a good idea to dput -s before you upload to
> make sure you don't do that for your first upload of a new version when
> someone else did the first upload.
>
> I'm curious. Why did you separate the patch that was sent into 2 patches?
>
> Regards,
> Daniel
>
>
>
> On Sat, Nov 17, 2018 at 10:06 PM Teus Benschop <teusjannette at gmail.com>
> wrote:
>
> > On Sat, 17 Nov 2018 at 15:46 Daniel Glassey <wdg at debian.org> wrote:
> >
> > > Yep :). Do you want to chase up the gconf one and see what upstream's
> > plans
> > > are for #912807 ?
> > >
> > > Yes, that's fine, I'll chase up that one.
> > --
> > Teus Benschop
> > teusjannette at gmail.com
> > 0318 712046 <0318%20712%20046>
> > _______________________________________________
> > pkg-crosswire-devel mailing list
> > pkg-crosswire-devel at alioth-lists.debian.net
> >
> >
> https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-crosswire-devel
> >
> _______________________________________________
> pkg-crosswire-devel mailing list
> pkg-crosswire-devel at alioth-lists.debian.net
>
> https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-crosswire-devel
>
-- 
Teus Benschop
teusjannette at gmail.com
0318 712046