Bug#370302: [Pkg-cryptsetup-devel] Bug#370302: a better recommendation for cryptdisks.functions

[David Härdeman]

On Sun, Jun 04, 2006 at 05:27:03PM +0200, General Stone wrote:
>In the attachment are patches for a better support on decrypted keys and
>to fix some little typing errors.

You seem to have forgotten the attachment.

>1) seperate the init-script and the decrypt-scripts so that anybody can
>
>
>   write his own decrypt-script without modify the init-script. The
>
>
>   decrypted key must be in "/tmp/cryptdisk.key" were it will be removed
>   after added a crypted disk.

/tmp might be noexec. It would be better to pipe the output of any 
key-generating script to stdin of cryptsetup. Take a look at how 
cryptgetpw in the initramfs hook/script works.

>2) The swap-check-script use the "strings" tool which is in "/usr/bin"
>   :-/. "egrep" can work with binarys so that work with "strings" is
>   needless.

A better solution would be to use fstype from klibc or libvol from 
udev to identify filesystem types.

Regards,
David