Bug#371135: [Pkg-cryptsetup-devel] Bug#371135: encrypted swap with variable key fails

[Jonas Meurer]

On 20/06/2006 Dick Middleton wrote:
> What I don't understand is why it's doing any checks at all when not 
> requested. It seems to me that checking for the existence of a 
> filesystem on an arbitrary partition is a bold assumption.  That is 
> properly the business of mount.

why do you see any problems? it does nothing else than checking for a
known filesystem before destroying any data on the source device.

you will never have a valid filesystem on a device that last has been
used as encrypted swap.

> But if having a default is generally deemed desirable then there must be 
> a checks=none capability or nochecks option.

that is true, at least for swap partitions. current implementation
always checks swap partitions.

i will try to summarize the changes that should be implemented in the
next version:

- add a checks=none option for swap
- check for valid fs on src device for plain dm-crypt swap per default
- check for LUKS device before any luksOpen, regardless if swap or not
- don't run other checks per default, but provide as many optional as
  reasonable

please correct me if i forgot something.

...
 jonas