Bug#371135: [Pkg-cryptsetup-devel] Bug#371135: encrypted swap with variable key fails

[Florian Weimer]

* Jonas Meurer:

> On 22/06/2006 Florian Weimer wrote:
>> * Jonas Meurer:
>> 
>> > why do you see any problems? it does nothing else than checking for a
>> > known filesystem before destroying any data on the source device.
>> 
>> The current setup doesn't work with volume managers and things like
>> that.  These don't have any partition types AFAIK.  Most people will
>> call the volume something which contains the string "swap", I guess,
>> so you could use that to check.  Or just note the expected volume size
>> in the configuration file.
>
> how do you mean? even if the source device is a logical volume, it may
> contain a filesystem.

If the volume name contains the string "swap", this is pretty
unlikely.

> the only cases that are known to me, where data loss may still occur
> are encrypted devices without an identifying header, like plain dm-crypt
> devices.

Logical volumes are in this category, too.

> i don't like the idea to check for string 'swap' in the source or target
> device, as this would enforce even more restrictions to the admin.

Currently, it does not work at all.  How could soemthing else be more
restrictive?

Anyway, what about my other suggestion, checking for the device size?