Bug#364153: [Pkg-cryptsetup-devel] Bug#364153: cryptsetup: timeout option leaves terminal in bad state

[Jonas Meurer]

On 12/05/2006 David Härdeman wrote:
> On Fri, May 12, 2006 at 01:09:33AM +0200, Jonas Meurer wrote:
> >On 10/05/2006 Andres Salomon wrote:
> >>> i've tested your patch, and it seems to work perfectly well.
> >>> but unfortunately this is only the case for the luks* features of
> >>> cryptsetup. Plain 'cryptsetup create' still leaves the terminal in a bad
> >>> state after terminating the passphrase prompt.
> >>> 
> >>> could you try to investigate that and update the patch to fix it as
> >>> well?
> >>
> >>I will do so; I've just been short on time lately.  Please ping me again
> >>in a few weeks if I've not sent you a patch.  My TODO queue is long. :(
> >
> >great. but David Härdeman has also written a patch to fix this. it would
> >be great, if you could take a look at 03_stdin_input.dpatch and
> >04_status_exit_codes.dpatch at debian/patches/ in the pkg-cryptsetup
> >svn trunk. these are the patches by David.
> 
> Hmm, actually I don't think my patches will fix anything related to 
> terminal being left in a bad state after timeout.

sorry, you're correct. i've mixed it with the truncated stdin input. my
fault.
still i'dd love to have more eyes on the patches against cryptsetup.
i claim to understand the code myself, but cryptsetup is a quite serious
package, and more eyes are always better than less.

andres, if you have some spare time, the terminal state of plain
cryptsetup timeout is still broken, and needs to be investigated. (or
david, same to you *g*).

greetings, and thanks to both of you for your great help,
 jonas