[Pkg-cryptsetup-devel] Bug#397633: Please use unique error messages (failed to determine cipher modules to load)

[Loïc Minier]

Package: cryptsetup
Version: 2:1.0.4-4
Severity: wishlist
File: /usr/share/initramfs-tools/hooks/cryptroot

        Hi,

 I currently get the error "cryptsetup: failed to determine cipher
 modules to load for /dev/mapper/bee--sata-root", but when looking at
 /usr/share/initramfs-tools/hooks/cryptroot, this error message is used
 twice (with a slight variation):
260: echo "$0: failed to determine cipher modules to load for $node" >&2
300: echo "cryptsetup: failed to determine cipher modules to load for $dev" >&2

 Please change one of these two messages; the first one appears below a
 "Load the config opts and modules for each device" block, so perhaps
 you might want to change the message to reflect this step, or to
 reflect that it is a consequence of an "add_device" call.

 Another option is to use $LINENO in all messages, this might not be
 POSIX.

   Thanks,

PS: yes, there's a small difference in the messages due to the use of $0
which is probably "cryptroot" in most cases, but you'll agree that this
is not practical for human to distinguish.

-- System Information:
Debian Release: 4.0
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.18-1-686
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)

Versions of packages cryptsetup depends on:
ii  dmsetup  2:1.02.08-1                     The Linux Kernel Device Mapper use
ii  libc6    2.3.6.ds1-8                     GNU C Library: Shared libraries
ii  libdevma 2:1.02.08-1                     The Linux Kernel Device Mapper use
ii  libgcryp 1.2.3-2                         LGPL Crypto library - runtime libr
ii  libgpg-e 1.4-1                           library for common error values an
ii  libpopt0 1.10-3                          lib for parsing cmdline parameters
ii  libuuid1 1.39+1.40-WIP-2006.10.02+dfsg-2 universally unique id library

cryptsetup recommends no packages.

-- no debconf information

-- 
Loïc Minier <lool at dooz.org>