[Pkg-cryptsetup-devel] updated cryptsetup package for ubuntu

[David Härdeman]

On Sun, February 4, 2007 10:01, Reinhard Tartler said:
<snip bzr stuff>
> Okay, now for the status update for cryptsetup in feisty: I've prepared
> a new merged package here (download it with `bzr get <url>`):
>
> https://code.launchpad.net/~siretart/+branch/cryptsetup/ubuntu
>
> I'm currently not at home yet, so I didn't have the change to test it
> properly, but there are no merge conflicts left, and I think we really
> should get to to feisty before the UVF (upstream version freeze) on
> Wednesday. It would be great if some more people could eyeball it and
> look if it can be uploaded to feisty.
>
> On https://bugs.launchpad.net/ubuntu/+source/cryptsetup/+bugs, there are
> a lot of bugs with patches, which need to be reviewed and integrated
> into the cryptsetup package. Many of them aren't that well thought, and
> need serious eyeballing, but this can safely be done after the UVF.

Agreed, I seem to recall going through the Ubuntu bugs once to look for
interesting patches and many of them looked quite scary, or hackish, or
based on a lack of understanding. That was just a quick review though and
memory might serve me wrong.

> The
> important patches in addition to the debian package is the usplash
> termination patch, and the console redirection for upstart.

I can't comment on upstart related patches as I've never tried it, but a
usplash termination patch sounds like a bad idea.

I wrote the patches to add support for user input to usplash with the
intention of using it in combination with cryptsetup (and the patches were
applied to usplash upstream months ago).

So rather than kill usplash, code like this:

  cryptsetup -x -y -z

could be replaced with something like:

  if [ -p /dev/.initramfs/usplash_outfifo ]; then
    usplash_write "INPUTQUIET Enter password for device $dev: "
    PASS="$(cat /dev/.initramfs/usplash_outfifo)"
    echo -n "$PASS" | cryptsetup -x -y -z
  else
    cryptsetup -x -y -z
  fi

(this was written from memory, not tested code so thread carefully)

I haven't implemented this in Debian yet because there has been no upload
of an updated usplash package in ages, but you should be able to take
advantage of the functionality in Ubuntu right now (I use it with a custom
built usplash locally and it's quite cool).

> I think both patches are interesting for debian as well. They can be
> found e.g. here:
> http://patches.ubuntu.com/c/cryptsetup/cryptsetup_2:1.0.4-8ubuntu2.patch.

That URL is a 404 for me, I'm guessing it changed to:
http://patches.ubuntu.com/c/cryptsetup/cryptsetup_2:1.0.4+svn26-1ubuntu1.patch
?

> I didn't forward them to debian yet, because I wanted to evaluate if
> the usplash patch applies to the debian splashy package as well, but I
> haven't found the time for it yet, sorry. The upstart patch, well,
> upstart can be found in debian/experimental as well, so I'm pretty sure
> it's necessary with that as well.

Probably, I'll keep an eye on it for post-Etch...perhaps you could file a
wishlist bug report in the Debian BTS once you have a final patch for
upstart support?

> Thank you for your attention so far, I hope you find this post
> interesting. Feel free to give me feedback about cryptsetup maintenance
> in ubuntu and debian, your plans with it, and also any problems you
> encounter with bzr-builddeb!

-- 
David Härdeman