[Pkg-cryptsetup-devel] [dm-crypt] list of patches for cryptsetup 1.0.5

Clemens Fruhwirth clemens at endorphin.org
Sat Oct 20 15:20:23 UTC 2007


Hello Jonas, 

First of all thanks for maintaining the list of patches!  Please make
liberal use of your commit privileges to the SVN repo. These are all
reasonable and small fixes, just Cc me and commit if you feel like.

Here are a few comments regarding the patches:

> Desc:   Improve the upstream manpage

Should be merged.

> Desc:   detect read-only devices automatically

In SVN.
 
> Desc:   stop cryptsetup from segfaulting with invalid device

In SVN.

> Desc:   check for UID == 0 before actually doing anything

As others pointed out, I'm not sure if that's really neccessary.

> Desc:   rename luksInit to luksFormat in libcrytsetup.h

In SVN.

> Desc:   run udevsettle after dm device creation

Should be merged.

> Desc:   fix some gcc warnings about unused or unitialized variables

Should be merged.

> Desc:   fix implicit function declarations

Should be merged.

> Desc:   fix segfault when trying to open a non existing device

I think that's fixed in SVN. Have to check.

> Desc:   use set_error instead of printf in library to report errors

Should be merged.

The cryptsetup SVN changes slightly refactoring a bit of stuff. If
some patch fails to apply or something else seems wrong, feel free to ask.

Thanks to all contributors.
-- 
Fruhwirth Clemens - http://clemens.endorphin.org 



More information about the Pkg-cryptsetup-devel mailing list