[pkg-cryptsetup-devel] Bug#491867: closed by Jonas Meurer <mejo at debian.org> (Bug#491867: fixed in cryptsetup 2:1.0.6-4)

[Jonas Meurer]

Hello,

On 10/09/2008 Helmut Grohne wrote:
> > Has this fix actually caused a problem with any system?
> 
> Actually no, I did not trash my system. I only verified that the swap
> signature does change and that the luks header is not properly
> destroyed. I then concluded under the false assumption that cryptsetup
> behaves consistent.
> 
> So let me propose changing other things:
>  * First of all it would be great if we could change man crypttab to
>    reflect this behaviour like "Run mkswap on the created device, but
>    not before /sbin/init is run." or "Run mkswap on the created device
>    unless it is used for resuming."

the crypttab manpage talks about behaviour of the initscripts which use
/etc/crypttab, and the initscripts indeed invoke mkswap when you give
swap as option. at resume, no initscript is invoked, thus mkswap isn't
invoked as well.

>  * Secondly in README.initramfs.gz according to my understanding step 6
>    should be useless, because step 4 already formated the device. A imho
>    better approach would be to keep step 6 and never let cryptsetup
>    invoke mkswap by removing that swap option if this change does not
>    break the sequence in another way.

You're correct about that one, and I finally removed step 6 from the
documentation. why don't you like the initscripts to invoke mkswap?
what's the advantage of doing that manually?

> I'd also be glad if README.initramfs.gz could be extended with more
> explanations on why and how this works, because the documentation of
> cryptsetup often made me read the source.

Feel free to provide patches :-)

I agree with you that better documentation would be great, but it's
already time consuming to maintain cryptsetup, and I don't have enough
time to write user documentation as well.

greetings,
 jonas