[Pkg-cryptsetup-devel] Bug#458944: Bug#458944: cryptsetup: Slightly wrong LSB header in init.d script

[Jonas Meurer]

On 04/01/2008 Petter Reinholdtsen wrote:
> [Petter Reinholdtsen]
> > This patch change this to be the case, and make sure the two scripts
> > are started in the order cryptdisk-early, cryptdisk, and stopped in
> > the opposite order even when dependency based boot sequencing is
> > used.
> 
> On second thought, and to reduce the complexity of initscripts while
> making cryptsetup more self contained, I recommend using a reverse
> dependency on checkfs in init.d/cryptdisk, to replace an optional
> dependency in checkfs on cryptdisk.  Here is the updated patch:

Hey Petter,

I think that your patch is not enough. cryptdisks-early needs to be
started before and stopped after lvm, evms, raid, etc.
cryptdisks needs to be started after and stopped before lvm, evms, raid,
etc.

therefore i would suggest something like:

### BEGIN INIT INFO
# Provides:          cryptdisks-early
# Required-Start:    checkroot
# Required-Stop:     umountroot
# Should-Start:      udev devfsd
# Should-Stop:       udev devfsd
# X-Start-Before:    raid2 mdadm lvm evms
# Default-Start:     S
# Default-Stop:      0 6
# Short-Description: Setup early encrypted block devices.
# Description:
### END INIT INFO

for cryptdisks-early, and the following for cryptdisks:

### BEGIN INIT INFO
# Provides:          cryptdisks
# Required-Start:    checkroot cryptdisk-early
# Required-Stop:     umountroot cryptdisk-early
# Should-Start:      udev devfsd raid2 mdadm lvm evms
# Should-Stop:       udev devfsd raid2 mdadm lvm evms
# X-Start-Before:    checkfs
# Default-Start:     S
# Default-Stop:      0 6
# Short-Description: Setup remaining encrypted block devices.
# Description:
### END INIT INFO

the relevant change is the X-Start-Before header for cryptdisks-early.

what do you think about it?

greetings,
 jonas