[Pkg-cryptsetup-devel] Bug#456326: Bug#456326: use udevadm instead of udevsettle

Jonas Meurer jonas at freesources.org
Sat Jan 19 00:26:35 UTC 2008


On 14/12/2007 Scott James Remnant wrote:
> udevadm merges all the old udev tools
> 
> *** /tmp/tmpxsyZ2u
> In Ubuntu, we've applied the attached patch to achieve the following:
> 
>   * debian/initramfs/cryptroot-script: call udevadm instead of udevsettle
>   * debian/patches/06_call_udevsettle.dpatch: likewise
> 
> We thought you might be interested in doing the same. 

Hey Scott,

Thanks for the patch, but unfortunately, udevadm is not available on
debian systems yet.

Additionally, the patch has some bugs:

> +++ cryptsetup-1.0.5/debian/initramfs/cryptroot-script
> @@ -159,8 +159,8 @@
>  		activate_evms $cryptsource
>  	fi
>  	# Wait for udev to be ready, see https://launchpad.net/bugs/85640
> -	if [ -x /sbin/udevsettle ]; then
> -		/sbin/udevsettle --timeout=30
> +	if [ -x /sbin/udevadm settle ]; then
> +		/sbin/udevadm settle --timeout=30
>  	fi

If i got it right, test accepts only binaries as argument against -x. At
least it doesn't support commandline options for the binary to test:

$ if [ -x /sbin/udevadm settle ]; then echo "yo"; fi
-bash: [: /sbin/udevadm: binary operator expected


> [...]
> +			/sbin/udevadm settle --timeout=30
> [...]
> diff -u cryptsetup-1.0.5/debian/patches/06_call_udevsettle.dpatch cryptsetup-1.0.5/debian/patches/06_call_udevsettle.dpatch
> --- cryptsetup-1.0.5/debian/patches/06_call_udevsettle.dpatch
> +++ cryptsetup-1.0.5/debian/patches/06_call_udevsettle.dpatch
> [...]
> ++	if (0 == access("/sbin/udevadm settle", X_OK)) {

the same problem here.

greetings,
 jonas





More information about the Pkg-cryptsetup-devel mailing list