[Pkg-cryptsetup-devel] Bug#488266: cryptsetup: use the correct destination in the cryptroot initramfs hook

[James Westby]

Package: cryptsetup
Version: 2:1.0.6-2
Severity: normal
Tags: patch
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu intrepid ubuntu-patch

Hi,

I'm not fully sure this affects Debian, as it seems like it is pretty
important, and something that would be noticed. However, in my
investigations I couldn't find a reason why it wouldn't, so I
am forwarding it to be sure.

The cryptroot initramfs-hook seems to copy the cryptsetup, dmsetup
and askpass binaries to the wrong location due to a missing second
argument. The following patch from Kjell Braden fixes this, please
consider applying it.

I also noticed that debian/initramfs/cryptopenct-hook also uses
copy_exec with no second argument in several places, so if this
is a bug then that hook should be checked as well.

Thanks,

James


diff -pruN 2:1.0.6-2/debian/initramfs/cryptroot-hook
2:1.0.6-2ubuntu7/debian/initramfs/cryptroot-hook
--- 2:1.0.6-2/debian/initramfs/cryptroot-hook	2008-06-20 22:19:57.000000000 +0100
+++ 2:1.0.6-2ubuntu7/debian/initramfs/cryptroot-hook	2008-06-20 22:16:41.000000000 +0100
@@ -478,9 +478,10 @@ if [ "$MODULES" != "dep" ] || [ "$setup"
 		manual_add_modules $mod
 	done
 
-	copy_exec /sbin/cryptsetup
-	copy_exec /sbin/dmsetup
-	copy_exec /lib/cryptsetup/askpass
+	copy_exec /sbin/cryptsetup /sbin
+	copy_exec /sbin/dmsetup /sbin
+	mkdir -p $DESTDIR/lib/cryptsetup
+	copy_exec /lib/cryptsetup/askpass /lib/cryptsetup/
 fi
 
 exit 0