[Pkg-cryptsetup-devel] Bug#488128: Bug#488128: Bug#488128: cryptsetup: Please support comments at the end of lines in /etc/crypttab

[David Härdeman]

On Fri, Jun 27, 2008 at 09:21:29AM +0100, James Westby wrote:
>On Fri, 2008-06-27 at 08:38 +0200, David Härdeman wrote:
>> On Thu, June 26, 2008 18:39, James Westby wrote:
>> > https://bugs.edge.launchpad.net/ubuntu/+source/cryptsetup/+bug/185380
>> >
>> > a user had problems due to attempting to use a comment at the end of the
>> > line in /etc/crypttab. It would be great if you could support this.
>> >
>> > The following patch by Reinhard Tartler is used in Ubuntu to allow
>> > this. Please consider applying it.
>> 
>> How can you know that someone isn't already using a "#" character in the
>> keyfile parameter of crypttab? (It isn't strictly paths only, it can be
>> any argument to a keyscript).
>> 
>
>Hi,
>
>That's a reasonable concern, and I hadn't considered that case.
>
>You are obviously far more familiar with the package that I, so you
>will be best judged to determine if there is more risk in adding
>the patch and giving problems to someone who is using a #, and the
>confusion to users who expect comments to be supported at the ends
>of lines.

Sorry, my bad, I read the patch too quickly. It only checks for comments 
in the "opts" field of crypttab (the fourth field) and cannot interfere 
with the keyfile parsing. I've committed the change to cryptsetup SVN.

Thanks.

-- 
David Härdeman