[pkg-cryptsetup-devel] Bug#548356: cryptsetup: Incorrect init.d dependency on mdadm (should be mdadm-raid)?

[Petter Reinholdtsen]

Package:  cryptsetup
Version:  2:1.0.6~pre1+svn45-1
Severity: important
Tags:     patch
User:     initscripts-ng-devel at lists.alioth.debian.org
Usertags: incorrect-dependency

I came across this issue when checking the init.d script dependencies
in the entire archive.  The cryptdisks and cryptdisk-early scripts
have a dependency on the mdadm facility, which do not seem to make
sense.  The mdadm facility starts in runlevels 2-5, while cryptdisks
and cryptdisks-early start in rcS.d/.  I suspect the init.d script
relationship should instead be to the mdadm-raid facility, which do
start in rcS.d/.  Here are the headers in question.  I've tested the
effect of this change on the entire archive to see if any new loops
were introduced, and no such problem were detected.  This make me
believe it is a safe thing to do.

Note that the devfsd init.d script relationship should probably be
removed.  There is no such script in any package in the Debian
archive.  It was made obsolete after Etch, I believe.  The same is the
situation for the evms and raid2 scripts.

Here is a patch to fix these issues.

diff -ur cryptsetup-1.0.7/debian/cryptdisks-early.init cryptsetup-1.0.7-pere/debian/cryptdisks-early.init
--- cryptsetup-1.0.7/debian/cryptdisks-early.init       2009-09-25 20:25:17.000000000 +0200
+++ cryptsetup-1.0.7-pere/debian/cryptdisks-early.init  2009-09-25 20:37:27.000000000 +0200
@@ -3,9 +3,9 @@
 # Provides:          cryptdisks-early
 # Required-Start:    checkroot
 # Required-Stop:     umountroot
-# Should-Start:      udev devfsd
-# Should-Stop:       udev devfsd
-# X-Start-Before:    mdadm lvm2 evms
+# Should-Start:      udev
+# Should-Stop:       udev
+# X-Start-Before:    mdadm-raid lvm2
 # X-Interactive:     true
 # Default-Start:     S
 # Default-Stop:      0 6
diff -ur cryptsetup-1.0.7/debian/cryptdisks.init cryptsetup-1.0.7-pere/debian/cryptdisks.init
--- cryptsetup-1.0.7/debian/cryptdisks.init     2009-09-25 20:25:17.000000000 +0200
+++ cryptsetup-1.0.7-pere/debian/cryptdisks.init        2009-09-25 20:37:35.000000000 +0200
@@ -3,8 +3,8 @@
 # Provides:          cryptdisks
 # Required-Start:    checkroot cryptdisks-early
 # Required-Stop:     umountroot cryptdisks-early
-# Should-Start:      udev devfsd raid2 mdadm lvm2 evms
-# Should-Stop:       udev devfsd raid2 mdadm lvm2 evms
+# Should-Start:      udev mdadm-raid lvm2
+# Should-Stop:       udev mdadm-raid lvm2
 # X-Start-Before:    checkfs
 # X-Interactive:     true
 # Default-Start:     S

Happy hacking,
-- 
Petter Reinholdtsen