[pkg-cryptsetup-devel] Bug#589029: closed by Jonas Meurer <mejo at debian.org> (Bug#589029: fixed in cryptsetup 2:1.1.3-2)

[Mario 'BitKoenig' Holbe]

package cryptsetup
reopen 589029
thanks

On Wed, Jul 21, 2010 at 09:33:13AM +0000, Debian Bug Tracking System wrote:
> Source-Version: 2:1.1.3-2
>    * introduce new variable $DEFAULT_LOUD. now the 'loud' option in crypttab
>      affects only the device in question. thanks to Mario 'BitKoenig' Holbe.
>    * introduce new crypttab option 'quiet' which overwrites and unsets the
>      'loud' option. thanks to Mario 'BitKoenig' Holbe. (closes: #589029)

This doesn't work yet:

# grep ^md9 /etc/crypttab
md9     /dev/md9        md1     luks,keyscript=decrypt_derived,quiet
# /etc/init.d/cryptdisks start
Starting remaining crypto disks...md1 (running)...md2 (running)...md3 (running)...md4 (running)...md5 (running)...md6 (running)...md71 (running)...md72 (running)...md73 (running)...md74 (running)...md8 (running)...md9 (skipped, device /dev/md9 does not exist)...failed.
done.

The reason for this is the dependency of the warning on the INITSTATE.
The first patch attached (01_cryptsetup-1.1.3-loud.patch) fixes this:
it initializes DEFAULT_LOUD in the init-scripts and depends the warning
on LOUD only.

There are 3 more patches attached with mainly cosmetic changes which I
stumbled upon while doing the fix and tests :) They apply
subsequentially in their numbered order.
Whether you like to apply them or not is IMHO just a matter of taste.

02_cryptsetup-1.1.3-cosmetics.patch is just cosmetics to
cryptdisks.functions:
* the LOUD initialization in the beginning doesn't harm but doesn't have
  any effect as well, it's the only initialization of an options
  variable outside parse_opts()
* the QUIET variable ist just never used
* if INITSTATE is empty, it does also not equal to "manual"

03_cryptsetup-1.1.3-isolate.patch isolates the initialization of
DEFAULT_LOUD to cryptdisks.functions. This simplifies the interface to
cryptdisks.functions, but requires to set the INITSTATE before sourcing
the file.

04_cryptsetup-1.1.3-quiet.patch disables the quiet mount option for
cryptdisks_start/stop. I like the idea, but ymmv.


regards
   Mario
-- 
*axiom* welcher sensorische input bewirkte die output-aktion,
        den irc-chatter mit dem nick "dus" des irc-servers
        mittels eines kills zu verweisen?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 01_cryptsetup-1.1.3-loud.patch
Type: text/x-diff
Size: 1382 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-cryptsetup-devel/attachments/20100722/8e1e418d/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 02_cryptsetup-1.1.3-cosmetics.patch
Type: text/x-diff
Size: 809 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-cryptsetup-devel/attachments/20100722/8e1e418d/attachment-0001.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 03_cryptsetup-1.1.3-isolate.patch
Type: text/x-diff
Size: 2562 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-cryptsetup-devel/attachments/20100722/8e1e418d/attachment-0002.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 04_cryptsetup-1.1.3-quiet.patch
Type: text/x-diff
Size: 441 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-cryptsetup-devel/attachments/20100722/8e1e418d/attachment-0003.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 482 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-cryptsetup-devel/attachments/20100722/8e1e418d/attachment.pgp>