[pkg-cryptsetup-devel] Bug#575024: Please support plymouth bootsplash

[Steve Langasek]

Sorry for not submitting this to Debian sooner; the cryptsetup delta in
Ubuntu is rather large, including extensive changes for upstart support, so
it's a challenge to pick out the bits that are currently relevant to Debian. 
I only caught sight of this bug report by way of Guido's blog.

I agree that this change would be good to have in Debian - I would quite
enjoy having plymouth working on my Debian systems for squeeze.  However,
the patch Guido sent will only add plymouth support for decryption of the
rootfs and the swap partition, since other devices are decrypted
post-initramfs, so another patch will be needed there for the init scripts.
I think the attached diff to cryptdisks.functions, also lifted from Ubuntu,
does the job.  If you have any questions, feel free to ask.

(This patch also changes the handling of random-crypted devices, by making
sure they're temp-mounted under /var/run/cryptsetup instead of under /tmp;
this is not immediately relevant to Debian, but paves the way for
udev-driven activation of crypted disks and upstart support, so I've
included it here rather than trying to disentangle the separate changes to
individual lines of code.)

The Ubuntu changelog entries corresponding to this change are as follows:

  * debian/cryptdisks.functions:
    - change interaction to use plymouth directly if present, and if not, to
      fall back to /lib/cryptsetup/askpass as before
  * debian/cryptdisk.functions: initially create the device under a temporary
    name and rename it only at the end using 'dmsetup rename', to ensure that
    upstart/mountall doesn't see our device before it's ready to go.
    LP: #475936.
  * cryptdisks.functions: do_tmp should mount under /var/run/cryptsetup for
    changing the permissions of the filesystem root, not directly on /tmp,
    since mounting on /tmp a) is racy, b) confuses mountall something fierce.
    LP: #475936.
  * cryptdisks.functions, debian/initramfs/cryptroot-script: fix the
    invocation of plymouth, so that we actually get proper passphrase prompts
    (once bug #496765 is fixed).
  * cryptdisks.functions: replace 'echo -e' bashism with 'printf'.

Cheers,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
slangasek at ubuntu.com                                     vorlon at debian.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cryptdisks-575024.diff
Type: text/x-diff
Size: 3943 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-cryptsetup-devel/attachments/20100325/eaad16cc/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 828 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-cryptsetup-devel/attachments/20100325/eaad16cc/attachment.pgp>