[pkg-cryptsetup-devel] Bug#554506: (ugly) patch which should fix dm-crypt-on-lvm setups

[Jonas Meurer]

Hey Christoph,

On 04/11/2010 Christoph Anton Mitterer wrote:
> I haven't fully looked at this so perhaps it's unrelated,...
> 
> But one main problem I see here (that may be related), is that lvm's
> init-scripts are simply wrong, and abusing some things.
> I've already told Bastian this and there are even several bugs open.
> 
> The problem is that lvm's init script simply doesn't to an lvchange -ay
> but try to detect the LV holding root.
> And it does this in a wrong way by using the root= kernel param (which
> is the final device, containing the root-fs)
> 
> Most lvm/dm-crypt realted I've seen were simply solvable by letting the
> lvm initscript just do an lvchange -ay (thereby making all LVs
> available) and then using dmcrypt/cryptsetup as normal.

while this bug is not related to init scripts at all, your suggestions
makes a lot of sense to me. after all, i don't see a reason to detect
the volume group with complicated dmsetup, sed and lvdisplay invokations
instead of just activating all volume groups globally in the initramfs.

attached patch removes any vg-guessing magic from the initramfs
cryptroot script, just invoking 'lvm vgchange -ay' instead.

thanks for the comment, Christoph!

greetings,
 jonas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cryptroot-script.diff
Type: text/x-diff
Size: 1990 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-cryptsetup-devel/attachments/20101104/5157276f/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-cryptsetup-devel/attachments/20101104/5157276f/attachment.pgp>