[pkg-cryptsetup-devel] Bug#610366: Hello and bug 610366

[Jonas Meurer]

Hello Rodolfo,

On 10/02/2011 Rodolfo kix Garcia wrote:
> my name is Rodolfo (AKA kix) and I am new in the mail list. I would
> like to help with the bugs, but I do not have much time.

all help is appreciated. thanks a lot.

> About the bug 610366,... the problem seems to be in the function
> _action_luksAddKey_useMK, because the first and second ifs returns a
> value to "r", and this value must be "0" to continue. But in the
> fourth "if" (_readk_mk(opt...), if the "if" fails, then the program
> flow goes to the out label and "r" continues with the value "0" from
> the second "if", therefore, the returns in the out section returns
> 0. This is the code:

unfortunately this bug already has been fixed by Milan upstream in the
meantime. see the svn commit #421 at
http://code.google.com/p/cryptsetup/source/detail?r=421

i even added the patch to the debian package in the packaging svn
repository. see
http://svn.debian.org/wsvn/pkg-cryptsetup/cryptsetup/trunk/?rev=848&sc=1
and
http://svn.debian.org/wsvn/pkg-cryptsetup/cryptsetup/trunk/debian/patches/01_luksAddKey_return_code.patch?rev=848&sc=1


i'm really sorry that your first attempt to help was somehow redundant.
my fault to not mention the fix in the buglog of bug #610366. that's
due to the reason that I maintained the package alone in the last years.
thus no immediate communication of applied fixes etc. was necessary.

to prevent this in future, i'll try to mention fixes in the buglog from
now on.

in order to reproduce bugs, i suggest to install virtual testsystems
(xen, kvm, virtualbox, vmware, ...). that way you can test several
different setups without messing with your main system.

and i suggest you to follow the svn repository at
svn://svn.debian.org/svn/pkg-cryptsetup/cryptsetup/trunk

the following two bugs should be easy to reproduce, but I didn't find
time to write a fix yet:

http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=521761
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=546610

and the following two bugs ask for implementation of a new feature,
patches would be great:

http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=515294
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=537842

greetings,
 jonas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-cryptsetup-devel/attachments/20110210/94559e87/attachment.pgp>