[pkg-cryptsetup-devel] Bug#601886: Bug#601886: cryptsetup: luksformat leaves the Luks device open

[Jonas Meurer]

Hello Milan, hey Bastian,

first thanks for your comments, Milan.

On 19/02/2011 Milan Broz wrote:
> On 02/19/2011 04:48 PM, Jonas Meurer wrote:
> > but i guess that the race condition is between libdevmapper and udev.
> > maybe this is related to the outdated devmapper (+udev rules) in debian?
> > 
> > on irc someone said that cryptsetup (luksClose) should wait for the
> > device to become free in case that udev sync is enabled.
> 
> device-mapper udev rules are constructed such way that after cryptsetup
> operation udev links processing should be finished.
> (iow dmsetup udevcomplete must be the last udev rule which manipulates
> with these links. Debian breaks it by reordering udev rules.)
> 
> (There is still race with "watch" udev rule but AFAIK only udisks
> using that - but this is not the case here.)
> 
> Sorry but I cannot help here until Debian maintaner wakes up and updates
> lvm/device-mapper udev rules. The changed Debian udev device-mapper rules
> are not supported by upstream.

Bastian, could you comment on your future plans for lvm2/devmapper? Do
you intend to package recent upstream, and replace the custom debian
udev rules by the upstream ones? If that's not the case, please
elaborate on why you don't intend to sync with the upstream udev rules.

> (You can add udevadm settle instead of sleep 1, but all these hacks are
> workarounds which are not needed with upstream.)

I'm happy to add this workaround as a temporary solution. But in the
long term I'd rather prefer to see these race condition fixed than
circumvented.

greetings,
 jonas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-cryptsetup-devel/attachments/20110219/9ee5bbf7/attachment.pgp>