[pkg-cryptsetup-devel] Bug#694499: breaks when used together with cryptsetup

[Steve Langasek]

reassign 694499 cryptsetup
severity 694499 important
tags 694499 patch
user ubuntu-devel at lists.ubuntu.com
usertags 694499 ubuntu-patch raring
thanks

On Tue, Nov 27, 2012 at 01:04:05AM +0100, Jelmer Vernooij wrote:
> (not sure whether this is a bug in the upstart files in cryptsetup or
> upstart)

> When using upstart together with cryptsetup, upstart hangs waiting for
> startpar right after boot. I also get an error on the console
> from initctl complaining that DEVNAME is not a valid level.

This is a bug in cryptsetup.  The cryptsetup package ships upstart jobs
under names that match the names of the pre-existing init scripts.  The
problem is that the upstart jobs and init scripts *are not equivalent*.  The
upstart job /etc/init/cryptdisks-early.conf creates one job instance per
crypto device.  This means that it does *not* generate the event necessary
to tell startpar that dependencies on /etc/init.d/cryptdisks-early are
satisfied, and so startpar, which knows about the upstart job, hangs
indefinitely waiting for a non-instance cryptdisks-early event which will
never occur.

I've attached a patch which corrects this, as well as correcting a shutdown
hang with cryptsetup.  Jonas, could you please apply this to cryptsetup in
unstable?

N.B., I believe cryptsetup is exempted from the requirement in Policy 9.11
to have upstart jobs carry "the same name as and equivalent functionality
to" the init script, because this integrates with /etc/rcS.d.

-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
slangasek at ubuntu.com                                     vorlon at debian.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cryptsetup-694499.patch
Type: text/x-diff
Size: 4246 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-cryptsetup-devel/attachments/20121126/ce4fd654/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-cryptsetup-devel/attachments/20121126/ce4fd654/attachment.pgp>