[pkg-cryptsetup-devel] Bug#826124: cryptsetup: improve crypttab thrid field = "none" handling

[Christoph Anton Mitterer]

Package: cryptsetup
Version: 2:1.7.0-2
Severity: wishlist


Hi.

Currently, documentation says:
"If the key file is the string “none”, a passphrase will be read interactively
from the console."

AFAIU the code, when ever it's "none", cryptkey won't be set, and as such
cryptkeyscript will be set to askpass and cryptkey to the prompt value for
that.


1) AFAIU, the documentation doesn't really explain that "none" overrides
   any defined keyscript, which AFAICS it does.
2) I think it would be better if "none" is only specially treated, if no
   keyscript is set (or if that was explicitly set to askpass), otherwise
   it should be simply handed over to the keyscript as is.
   This would also allow other keyscript to use the value "none", if they
   should want to.
   
   In other words:
   no keyscript => if keyfile == none => askpass
                   if keyfile != none => try to use as file
   keyscript = explicitly askpass => take keyfile as prompt value for askpass
                                     i.e. even if it's "none"
   keyscript = something else => pass keyfile value on as is (including
                                 "none")


Cheers,
Chris.