[pkg-cryptsetup-devel] Bug#839888: syntax error in do_start, preventing unlock of cryptdisks on boot

[Marc Haber]

Package: cryptsetup
Version: 2:1.7.2-1
Severity: critical
Tags: patch

Hi,

the following patch against cryptdisks.function was necessary to make
my system come up again. Without, unlock of my file systems failed,
due to the shell syntax error in the changed line, making the system
unbootable.

--- /cryptdisks.functions       2016-10-06 08:29:19.324037677 +0200
+++ /lib/cryptsetup/cryptdisks.functions        2016-10-06 08:29:31.992037978 +0200
@@ -742,7 +742,7 @@
                if [ "${dev_match#UUID=}" != "$dev_match" ]; then
                        dev_match="$(readlink -f /dev/disk/by-uuid/${dev_match#UUID=})"
                elif [ "${dev_match#LABEL=}" != "$dev_match" ]; then
-                       dev_match="$(readlink -f /dev/disk/by-label/$(printf '%s' "${dev_match#LABEL=})" | sed 's,/,\\x2f,g')"
+                       dev_match="$(readlink -f /dev/disk/by-label/$(printf '%s' "${dev_match#LABEL=}") | sed 's,/,\\x2f,g')"
                fi
                # only required for the (ubuntu) upstart init system:
                # if there's already a udev-triggered job running for this

Greetings
Ma "was this code ever tested once?" rc


-- Package-specific info:

-- System Information:
Debian Release: stretch/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.7.6-zgws1 (SMP w/4 CPU cores)
Locale: LANG=en_DK.utf8, LC_CTYPE=en_DK.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages cryptsetup depends on:
ii  cryptsetup-bin         2:1.7.2-1
ii  debconf [debconf-2.0]  1.5.59
ii  dmsetup                2:1.02.133-1
ii  libc6                  2.24-3

Versions of packages cryptsetup recommends:
ii  busybox                                 1:1.22.0-19
ii  console-setup                           1.150
ii  initramfs-tools [linux-initramfs-tool]  0.125
ii  kbd                                     2.0.3-2

Versions of packages cryptsetup suggests:
ii  dosfstools              4.0-2
ii  keyutils                1.5.9-9
ii  liblocale-gettext-perl  1.07-3+b1

-- debconf information:
  cryptsetup/prerm_active_mappings: true

-- debsums errors found:
debsums: changed file /lib/cryptsetup/cryptdisks.functions (from cryptsetup package)