[pkg-cryptsetup-devel] Bug#916649: Bug#916649: crytpsetup:

[rsev at riseup.net]

On 2018-12-16 23:43, Guilhem Moulin wrote:
> Control: retitle  -1 `/etc/init.d/cryptdisks stop` should ignore
> devices holding / and /usr
> Control: severity -1 wishlist
> 
> Hi,
> 
> On Sun, 16 Dec 2018 at 13:28:37 -0800, rsev at riseup.net wrote:
>> When shuting down my Devuan LVM + LUKS install, it hangs just at the end
>> of the shutdown sequence presenting messages like "sda5_crypt is busy"
>> and "sdb_crypt is busy". Only after 30 seconds or so pass, it acatully
>> shuts down.
> 
> https://tracker.debian.org/news/181876/accepted-lvm2-20284-3-source-amd64/
> 
>> Aplying one the patchs available at
>> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=792552#5 or
> 
> Which patch?  something equivalent to #5 is already present in 2:1.7.3-4

When I manually applied the patch from #5, my shutdown sequence worked
just fine (without hanging).

> Or do you mean `dmsetup remove_all` from #24? 

Didn't try that. I can't say if it would work. 

> Like for
> 
>> https://bugs.devuan.org//cgi/bugreport.cgi?bug=237 fixes the problems
>> just fine for me.

The patch available here also solved this issue for me. Just to be
clear, either one of the patches, apllied separately, solved this issue
for me.

> /etc/init.d/lvm2 no longer deactivates LVs on shutdown since lvm2
> ≥2.02.84-3.  But I don't see which doing so should be the job of
> /etc/init.d/cryptsetup instead.

I understand your reasoning. So this should be changed from a cryptsetup
bug to a lvm one?

> Regardless, we won't be able to lock devices holding / or /usr.  AFAICT
> that's where `/etc/init.d/cryptdisks stop` is choking with the repeated
> “… is busy” messages.  For these devices the script might as well return
> failure immediately and not try again.

That sounds like a rather _brute_ solution but it might just as well
work.


Regards,

Rodrigo