[pkg-cryptsetup-devel] Bug#916649: /lib/cryptsetup/cryptdisks-functions: Re: `/etc/init.d/cryptdisks stop` should ignore devices holding / and /usr

[Christopher Bayliss]

Package: cryptsetup-run
Version: 2:2.1.0-4
Followup-For: Bug #916649

G'day!

[NOTE:: I was going to submit a new bug, wrote this up, then found the issue
was already reported in #918008, then merged into this bug (#916649). So I'm
adding a comment to confirm that the issue occurs in debian buster]

When I power off my luks encrypted debian buster system, I get this message:

Stopping remaining crypto disks... sda3_crypt busy...

And 'sda3_crypt busy...' repeats multiple times for about 30 seconds, then a
fail message in red is shown too quickly for me to see and the system halts.

I'm running sysvinit (from the sysvinit-core package) and sysv-rc. This system
is a fresh install I did over the weekend, and due to other unrelated issues,
I reinstalled twice. Each install had the same issue under sysvinit at
shutdown, I have not tested under systemd.

To replicate the issue:

    1. Install debian buster with the multi-boot netinst buster RC1 installer.[1]
    2. During installation partition with the luks auto partitioner with "all files in one partition" option
    3. During installation unselect all tasksel options, including standard utilities.
    4. After installation install sysvinit-core with: apt install sysvinit-core --no-install-recommends
    5. Reboot, then purge systemd with: apt purge systemd

Maintainer, I apologise I'm unable to test this in a qemu where I can get a
screen recording I could playback slowly to see the fail message, I just don't
have enough internet data to install debian for the fourth time time :/

I can't find anything meaningful in /var/log/syslog:

Jun  9 23:42:44 aster acpid: client 1625[1000:1000] has disconnected
Jun  9 23:42:48 aster shutdown[2333]: shutting down for system halt
Jun  9 23:42:48 aster init: Switching to runlevel: 0
Jun  9 23:42:48 aster shutdown[2353]: shutting down for system halt

and /var/log/faillog is useless data:

root at aster:~# file /var/log/faillog
/var/log/faillog: data
root at aster:~#

[1] https://cdimage.debian.org/cdimage/buster_di_rc1/multi-arch/iso-cd/

-- Package-specific info:
-- /proc/cmdline
BOOT_IMAGE=/vmlinuz-4.19.48 root=/dev/mapper/aster--vg-root ro video=SVIDEO-1:d

-- /etc/crypttab
sda3_crypt UUID=f8bdb1d3-81ca-43ef-af5d-25d073184cdd none luks,discard

-- /etc/fstab
# /etc/fstab: static file system information.
#
# Use 'blkid' to print the universally unique identifier for a
# device; this may be used with UUID= as a more robust way to name devices
# that works even if disks are added and removed. See fstab(5).
#
# <file system> <mount point>   <type>  <options>       <dump>  <pass>
/dev/mapper/aster--vg-root /               ext4    errors=remount-ro 0       1
# /boot was on /dev/sda2 during installation
UUID=39e8ceff-d65a-429b-9b64-f9816213a583 /boot           ext2    defaults        0       2
# /boot/efi was on /dev/sda1 during installation
UUID=FCD6-C461  /boot/efi       vfat    umask=0077      0       1
/dev/mapper/aster--vg-swap_1 none            swap    sw              0       0

-- lsmod
Module                  Size  Used by


-- System Information:
Debian Release: 10.0
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 4.19.48 (SMP w/2 CPU cores)
Kernel taint flags: TAINT_RANDSTRUCT
Locale: LANG=en_AU.UTF-8, LC_CTYPE=en_AU.UTF-8 (charmap=UTF-8), LANGUAGE=en_AU:en (charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: sysvinit (via /sbin/init)

Versions of packages cryptsetup-run depends on:
ii  cryptsetup-bin         2:2.1.0-4
ii  debconf [debconf-2.0]  1.5.71
ii  dmsetup                2:1.02.155-2
ii  libc6                  2.28-10

cryptsetup-run recommends no packages.

Versions of packages cryptsetup-run suggests:
pn  dosfstools              <none>
pn  keyutils                <none>
ii  liblocale-gettext-perl  1.07-3+b4

-- debconf information:
  cryptsetup/prerm_active_mappings: true