[pkg-cryptsetup-devel] any reason why askpas blocks all signals?

[David Härdeman]

October 11, 2021 10:57 PM, "Christoph Anton Mitterer" <calestyo at scientia.net> wrote:
> (I took the liberty to add David Härdeman and Jonas Meurer to CC, who
> have made the most commits on askpass,... maybe they can help me to
> clarify why signals were blocked in askpass in the first place. See [0]
> for the original thread.)
...
> As written before, I don't know why signals were blocked in the first
> place, but if the only reason was also the partial passphrase
> possibility, we could also just move the whole blocking of signals down
> to the place before the passphrase is printed.

Hey,

I wrote the initial version of askpass. I'm not 100% sure anymore (it was a long time ago), but I think the reason all signals were blocked is just because it was the simplest way to "deal" with signals (i.e. by ignoring them completely) under the assumption that you wouldn't realistically want to interfere with askpass as it's (normally) a prerequisite for continuing the boot process.

I don't think there's any harm in allowing some signals if there are use-cases for that.

Cheers,
David