[pkg-cryptsetup-devel] Bug#1128538: cryptsetup: FTBFS with glibc 2.43 due to ISO C23 const return types

[Aurelien Jarno]

Source: cryptsetup
Version: 2:2.8.4-1
Severity: important
Tags: ftbfs
Justification: fails to build from source
User: debian-glibc at lists.debian.org
Usertags: glibc-2.43

Dear maintainer(s),

cryptsetup fails to build from source with glibc 2.43, currently in
experimental. From the build log:

|    debian/rules execute_after_dh_auto_build
| make[1]: Entering directory '/build/reproducible-path/cryptsetup-2.8.4'
| # build askpass and passdev keyscripts
| aarch64-linux-gnu-gcc -o debian/askpass debian/askpass.c -Wall -Werror -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/reproducible-path/cryptsetup-2.8.4=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -Wdate-time -D_FORTIFY_SOURCE=2 -Wl,-z,relro -Wl,-z,now -pedantic
| debian/askpass.c: In function ‘console_prepare’:
| debian/askpass.c:416:26: error: assignment discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
|   416 |         while ( (newline = strstr(prompt_ptr,"\\n")) != NULL ) {
|       |                          ^
| cc1: all warnings being treated as errors
| make[1]: *** [debian/rules:33: execute_after_dh_auto_build] Error 1
| make[1]: Leaving directory '/build/reproducible-path/cryptsetup-2.8.4'
| make: *** [debian/rules:19: binary] Error 2
| dpkg-buildpackage: error: debian/rules binary subprocess failed with exit status 2

The full build log is available here [1].

The issue is due to ISO C23 declaration of bsearch, memchr, strchr,
strpbrk, strrchr, strstr, wcschr, wcspbrk, wcsrchr, wcsstr and wmemchr,
which now returns a pointer to a const-qualified type when the input
argument is a pointer to a const-qualified type [2].

I would like to thanks Emanuele Rocca for doing the archive rebuild on
a fast arm64 server.

Regards
Aurelien

[1] https://people.debian.org/~ema/glibc-2.43-rebuilds/output-1/cryptsetup_arm64.build
[2] https://sourceware.org/git/?p=glibc.git;a=blob;f=NEWS;h=e271fb2e4d76903c77a302aaec1ca22ce31027d0;hb=f762ccf84f122d1354f103a151cba8bde797d521#l19

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien at aurel32.net                     http://aurel32.net