Debhelper-generated postinst and prerm vs. manual one

[Roberto C. Sanchez]

On Sat, Oct 21, 2006 at 10:40:15AM +0300, Fabian Fagerholm wrote:
> On Fri, 2006-10-20 at 17:43 -0400, Roberto C. Sanchez wrote:
> > I disagree.  Please take another look at #257181.  While I understand
> > that if START=yes is not set, the daemon is disabled, I don't think that
> > the exit code if `invoke-rc.d saslauthd start` should be 0 if the daemon
> > does not actually start.
> 
> The exit code does not indicate whether or not the deamon started. It
> indicates whether the script succeeded with what it was supposed to do.
> Some init scripts even include a "status" option that checks if the
> daemon is running or not. Other daemons have other means, such as pid
> files, lock files, status commands sent over sockets, and so on.
> 
Hmm.  I guess that makes sense.

> And as hmh said, invoke-rc.d is to be used only by the maintainer
> scripts and other Debian infrastructure.
> 
Understood.

> On Fri, 2006-10-20 at 17:43 -0400, Roberto C. Sanchez wrote:
> > On Fri, Oct 20, 2006 at 04:22:27PM -0300, Henrique de Moraes Holschuh
> > wrote:
> > > This goes against both KISS and the principle of least surprise.  If no
> > > mechs are defined, bombing out with an error is best IMHO.  Just make sure
> > > the default for the package is to have START disabled so that saslauth is
> > > not started by default in unconfigured state.
> > > 
> > I agree.
> 
> I thought you said you prefer to fall back to a sane default ("pam", for
> example)?
> 
I do.  I was agreeing with laeving it disabled by default.  However, the
admin should simply be able to put "START=yes" in the defaults file and
have it startm even if no mechs are defined, since pam is a sane
default.  Apologies for not being more clear.

> Anyway, I've read all the comments and I've committed the attached patch.
> 
OK.

> Has anyone actually tried starting saslauthd with this init script? I
> never finished writing and testing the parts that actually start and
> stop it...
> 
I've not test with your patch yet.

Regards,

-Roberto

-- 
Roberto C. Sanchez
http://people.connexer.com/~roberto
http://www.connexer.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.alioth.debian.org/pipermail/pkg-cyrus-sasl2-debian-devel/attachments/20061021/f181e001/attachment.pgp