Request for pre-approval of cyrus-sasl2 upload

[Julien Cristau]

On Sun, Aug 22, 2010 at 15:36:50 -0400, Roberto C. Sánchez wrote:

> On Sun, Aug 22, 2010 at 02:28:37PM -0400, Roberto C. Sánchez wrote:
> > 
> > Assuming that my explanations are satisfactory, did you want to see a
> > new diff for placing the configure options into a variable?
> > 
> I went ahead and finished making the changes just now.  The updated diff
> is attached.
> 
I should have spotted this last time, but I'm afraid this:

+       (mkdir $(TMPBUILD_MIT); cd $(TMPBUILD_MIT); \
+       LDFLAGS="$(LDFLAGS) -L/usr/lib/mit-krb5 -Wl,-z,defs"
CFLAGS="$(CFLAGS)" CPPFLAGS="$(CPPFLAGS) -I/usr/include/mit-krb5"
../configure \
+               $(CONFIGURE_COMMON_OPTIONS) \
+               --with-gss_impl=mit; \
+       cd ..)

is going to succeed even if configure doesn't.  Should probably use
something like

        mkdir $(TMPBUILD_MIT)
        cd $(TMPBUILD_MIT) && \
        LDFLAGS="$(LDFLAGS) -L/usr/lib/mit-krb5 -Wl,-z,defs" \
        CFLAGS="$(CFLAGS)" CPPFLAGS="$(CPPFLAGS) -I/usr/include/mit-krb5" \
        ../configure $(CONFIGURE_COMMON_OPTIONS) --with-gss_impl=mit

i.e. without the unnecessary subshell and '; cd ..' after configure.
Probably same with the $(MAKE) invocation.

Cheers,
Julien
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-cyrus-sasl2-debian-devel/attachments/20100823/9721f3df/attachment.pgp>