[Pkg-deepin-devel] Bug#927331: dde-qt-dbus-factory: symbols adjustments to support build with -O3

Steve Langasek steve.langasek at canonical.com
Thu Apr 18 06:40:04 BST 2019


Package: dde-qt-dbus-factory
Version: 1.1.0-2
Severity: minor
Tags: patch
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu disco ubuntu-patch

Dear maintainers,

The latest version of dde-qt-dbus-factory, 1.1.0-2, fails to build from
source on ppc64el in Ubuntu due to a difference in the symbols output for
the shared library.  This is because Ubuntu defaults to -O3 on ppc64el,
which means there are changes to some template or inline symbols added or
removed from the output, when compared with building with -O2.

Since these are template symbols and not part of the shared library ABI, a
correct fix to make the library compatible with -O3 is to mark these symbols
optional as in the attached patch.  Please consider applying in Debian.

Thanks,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                   https://www.debian.org/
slangasek at ubuntu.com                                     vorlon at debian.org
-------------- next part --------------
diff -Nru dde-qt-dbus-factory-1.1.0/debian/libdframeworkdbus2.symbols dde-qt-dbus-factory-1.1.0/debian/libdframeworkdbus2.symbols
--- dde-qt-dbus-factory-1.1.0/debian/libdframeworkdbus2.symbols	2019-02-26 04:49:19.000000000 -0800
+++ dde-qt-dbus-factory-1.1.0/debian/libdframeworkdbus2.symbols	2019-04-17 20:42:46.000000000 -0700
@@ -391,8 +391,8 @@
  _ZN11__Bluetooth14DisplayPinCodeERK15QDBusObjectPathRK7QString at Base 1.0.1
  _ZN11__Bluetooth14RequestPasskeyERK15QDBusObjectPath at Base 1.0.1
  _ZN11__Bluetooth14RequestPinCodeERK15QDBusObjectPath at Base 1.0.1
- _ZN11__Bluetooth14SetDeviceAliasERK15QDBusObjectPathRK7QString at Base 1.1.0
- _ZN11__Bluetooth15SetAdapterAliasERK15QDBusObjectPathRK7QString at Base 1.1.0
+ (optional=inline)_ZN11__Bluetooth14SetDeviceAliasERK15QDBusObjectPathRK7QString at Base 1.1.0
+ (optional=inline)_ZN11__Bluetooth15SetAdapterAliasERK15QDBusObjectPathRK7QString at Base 1.1.0
  _ZN11__Bluetooth16staticMetaObjectE at Base 1.0.1
  _ZN11__Bluetooth17FeedPasskeyQueuedERK15QDBusObjectPathbj at Base 1.1.0
  _ZN11__Bluetooth17FeedPinCodeQueuedERK15QDBusObjectPathbRK7QString at Base 1.1.0
@@ -400,10 +400,12 @@
  _ZN11__Bluetooth19RequestConfirmationERK15QDBusObjectPathRK7QString at Base 1.0.1
  _ZN11__Bluetooth20RequestAuthorizationERK15QDBusObjectPath at Base 1.0.1
  _ZN11__Bluetooth21onPendingCallFinishedEP23QDBusPendingCallWatcher at Base 1.0.1
+ (optional=inline)_ZN11__Bluetooth22SetAdapterDiscoverableERK15QDBusObjectPathb at Base 1.1.0
  _ZN11__Bluetooth23DevicePropertiesChangedERK7QString at Base 1.0.1
  _ZN11__Bluetooth24AdapterPropertiesChangedERK7QString at Base 1.0.1
  _ZN11__Bluetooth29SetAdapterDiscoverableTimeoutERK15QDBusObjectPathj at Base 1.1.0
  _ZN11__Bluetooth5stateEv at Base 1.0.1
+ (optional=inline)_ZN11__Bluetooth7ConfirmERK15QDBusObjectPathb at Base 1.1.0
  _ZN11__Bluetooth9CancelledERK15QDBusObjectPath at Base 1.0.2
  _ZN11__BluetoothC1ERK7QStringS2_RK15QDBusConnectionP7QObject at Base 1.0.1
  _ZN11__BluetoothC2ERK7QStringS2_RK15QDBusConnectionP7QObject at Base 1.0.1
@@ -1275,6 +1277,7 @@
  (optional=templinst)_ZN4QMapI7QString8QVariantED1Ev at Base 1.0.1
  (optional=templinst)_ZN4QMapI7QString8QVariantED2Ev at Base 1.0.1
  (optional=templinst)_ZN4QMapI7QStringP23QDBusPendingCallWatcherE13detach_helperEv at Base 1.1.0
+ (optional=templinst)_ZN4QMapI7QStringP23QDBusPendingCallWatcherE6removeERKS0_ at Base 1.1.0
  (optional=templinst)_ZN4QMapI7QStringS0_EC1ERKS1_ at Base 1.0.1
  (optional=templinst)_ZN4QMapI7QStringS0_EC2ERKS1_ at Base 1.0.1
  (optional=templinst)_ZN4QMapI7QStringS0_ED1Ev at Base 1.0.1
@@ -1830,7 +1833,7 @@
  _ZN8__DeviceD1Ev at Base 1.0.1
  _ZN8__DeviceD2Ev at Base 1.0.1
  _ZN8__Login110CallQueuedERK7QStringRK5QListI8QVariantE at Base 1.0.1
- (arch=!armel !armhf !i386 !m68k !mips !mipsel !powerpc !powerpcspe)_ZN8__Login110GetSessionERK7QString at Base 1.1.0
+ (arch=!armel !armhf !i386 !m68k !mips !mipsel !powerpc !powerpcspe|optional=inline)_ZN8__Login110GetSessionERK7QString at Base 1.1.0
  _ZN8__Login110SessionNewERK7QStringRK15QDBusObjectPath at Base 1.0.1
  _ZN8__Login110idleActionEv at Base 1.0.1
  _ZN8__Login111KillSessionERK7QStringS2_i at Base 1.0.1
@@ -1847,7 +1850,7 @@
  _ZN8__Login113idleSinceHintEv at Base 1.0.1
  _ZN8__Login113inhibitorsMaxEv at Base 1.0.1
  _ZN8__Login113killOnlyUsersEv at Base 1.0.1
- (arch=armel armhf i386 m68k mips mipsel powerpc powerpcspe)_ZN8__Login114KillUserQueuedEji at Base 1.1.0
+ (arch=armel armhf i386 m68k mips mipsel powerpc powerpcspe ppc64el|optional=inline)_ZN8__Login114KillUserQueuedEji at Base 1.1.0
  _ZN8__Login114SessionRemovedERK7QStringRK15QDBusObjectPath at Base 1.0.1
  _ZN8__Login114SetWallMessageERK7QStringb at Base 1.0.1
  _ZN8__Login114blockInhibitedEv at Base 1.0.1
@@ -1855,7 +1858,7 @@
  _ZN8__Login114handlePowerKeyEv at Base 1.0.1
  _ZN8__Login114idleActionUSecEv at Base 1.0.1
  _ZN8__Login114setWallMessageERK7QString at Base 1.0.1
- (arch=armel armhf i386 m68k mips mipsel powerpc powerpcspe)_ZN8__Login115GetSessionByPIDEj at Base 1.1.0
+ (arch=armel armhf i386 m68k mips mipsel powerpc powerpcspe ppc64el|optional=inline)_ZN8__Login115GetSessionByPIDEj at Base 1.1.0
  _ZN8__Login115PrepareForSleepEb at Base 1.0.1
  _ZN8__Login115handleLidSwitchEv at Base 1.0.1
  _ZN8__Login116ScheduleShutdownERK7QStringy at Base 1.1.0
@@ -1875,7 +1878,7 @@
  _ZN8__Login118nCurrentInhibitorsEv at Base 1.0.1
  _ZN8__Login119SetUserLingerQueuedEjbb at Base 1.0.1
  _ZN8__Login119inhibitDelayMaxUSecEv at Base 1.0.1
- (arch=!armel !armhf !i386 !m68k !mips !mipsel !powerpc !powerpcspe)_ZN8__Login120SetWallMessageQueuedERK7QStringb at Base 1.1.0
+ (arch=!armel !armhf !i386 !m68k !mips !mipsel !powerpc !powerpcspe|optional=inline)_ZN8__Login120SetWallMessageQueuedERK7QStringb at Base 1.1.0
  _ZN8__Login120preparingForShutdownEv at Base 1.0.1
  _ZN8__Login120runtimeDirectorySizeEv at Base 1.0.1
  _ZN8__Login121ActivateSessionOnSeatERK7QStringS2_ at Base 1.0.1
@@ -1887,8 +1890,8 @@
  _ZN8__Login122idleSinceHintMonotonicEv at Base 1.0.1
  _ZN8__Login127ActivateSessionOnSeatQueuedERK7QStringS2_ at Base 1.1.0
  _ZN8__Login16dockedEv at Base 1.0.1
- (arch=!alpha !amd64 !arm64 !hurd-i386 !kfreebsd-amd64 !kfreebsd-i386 !mips64el !ppc64 !ppc64el !riscv64 !s390x !sh4 !sparc64 !x32)_ZN8__Login17GetSeatERK7QString at Base 1.1.0
- _ZN8__Login17GetUserEj at Base 1.1.0
+ (arch=!alpha !amd64 !arm64 !hurd-i386 !kfreebsd-amd64 !kfreebsd-i386 !mips64el !ppc64 !riscv64 !s390x !sh4 !sparc64 !x32|optional=inline)_ZN8__Login17GetSeatERK7QString at Base 1.1.0
+ (optional=inline)_ZN8__Login17GetUserEj at Base 1.1.0
  _ZN8__Login17InhibitERK7QStringS2_S2_S2_ at Base 1.0.1
  _ZN8__Login17SeatNewERK7QStringRK15QDBusObjectPath at Base 1.0.1
  _ZN8__Login17UserNewEjRK15QDBusObjectPath at Base 1.0.1


More information about the Pkg-deepin-devel mailing list