[Pkg-deepin-devel] Bug#1136492: dde-calendar uses pidof but does not depend on procps

[Gioele Barabucci]

Source: dde-calendar
Version: 5.14.13-1
Usertags: pidof-without-procps

Dear maintainer(s) of dde-calendar,

it appears that dde-calendar uses `pidof` in its testsuite, or that
at least one of its binary packages uses `pidof` at runtime.
Historically, `pidof` was provided by the Essential package
`sysvinit-tools`, making an explicit dependency unnecessary. However
`pidof` will soon be moved to `procps` and will no longer be part of
the Essential set.

Please add an explicit dependency on `procps`:

* via the `Depends:` field of all binary packages of dde-calendar
  that use `pidof` at runtime;
* via the `Build-Depends:` field of dde-calendar, if `pidof` is
  used in tests run at build-time;
* via the `Depends:` field of `debian/control/tests`, if `pidof` is
  used in autopkgtests.

To prevent any disruption for users of dde-calendar, please add
this dependency now, before `pidof` is moved from `sysvinit-utils` to
`procps`. Alternatively, you could remove all uses of `pidof`.

It is believed that dde-calendar uses `pidof` due to the following
code snippets:

```
path: dde-calendar_5.14.13-1/calendar-service/src/calendarDataManager/daccountmanagemodule.cpp
    QProcess process;
    process.start("/bin/bash", QStringList() << "-c"
                  << "pidof dde-calendar");
    process.waitForFinished();
    QString strResult = process.readAllStandardOutput();
```

Feel free to close this issue if this is a false positive (for example
if this code is in an unreachable code path).

Regards,

-- 
Gioele Barabucci