[Pkg-dpdk-devel] Bug#953298: dpdk: please review the hwdata dependency

[Luca Boccassi]

Control: tags -1 pending

On Sat, 07 Mar 2020 11:47:40 +0100 Pino Toscano <pino at debian.org>
wrote:
> Source: dpdk
> Version: 18.11.6-1
> Severity: wishlist
> Control: block 944500 by -1
> 
> Hi,
> 
> currently a binary of the dpdk source depends on hwdata.
> 
> This is most probably done because dpdk requires (or can
> optionally use) any of pci.ids, pnp.ids, and usb.ids.
> Considering that:
> - pci.ids and usb.ids have always been provided by pciutils and
>   usbutils instead of hwdata upstream, with symlinks provided by the
>   hwdata Debian package
> - pciutils, and usbutils provide also utilities
> - pci.ids and usb.ids were recently split in their own packages
> - hwdata at the moment depends on pciutils, and usbutils
> it is a good occasion to review the hwdata dependency.
> 
> The first checklist is package relationships to add to the binaries
of
> the dpdk source:
> 1) pci.ids: if the pci.ids file can be used from the /usr/share/misc
>    directory
> 2) usb.ids: if the usb.ids file can be used from the /usr/share/misc
>    directory
> 3) pciutils: if any of the /usr/bin/lspci, /usr/bin/setpci, and
>    /usr/sbin/update-pciids commands is used
> 4) usbutils: if any of the /usr/bin/lsusb, /usr/bin/usb-devices,
>    /usr/bin/usbhid-dump, and /usr/bin/usbreset commands is used
> 
> The second checklist is criteria to determine whether the hwdata
> dependency must be kept:
> a) the pci.ids file is used only if in the /usr/share/hwdata
directory
> b) the usb.ids file is used only if in the /usr/share/hwdata
directory
> c) the /usr/share/hwdata/pnp.ids file is used
> If none of the criteria above match, please drop the hwdata
dependency.
> 
> As it can be implied from the two checklists above, a perfectly valid
> resolution of this bug is to close it in case there are no changes
> required. If you do so, please leave a note describing the situation,
> and how hwdata is used, so it is easier for the hwdata maintainer
> (currently me) to know the status.
> 
> Starting from version 0.290-2, hwdata is "Multi-Arch: foreign", so
> there is no problem using it also in "Multi-Arch: same" packages.
> 
> In case of questions/doubts/etc, please do not hesitate to contact
me.
> 
> Thanks!
> -- 
> Pino

Hi,

Thanks for the report, we need /usr/share/hwdata/pci.ids. I've sent a
patch upstream to try first /usr/share/misc/pci.ids if it exists, and
I'll backport it once accepted, and switch the dependency from hwdata
to pci.ids.

We already depend on pciutils and we need it for lspci, so that one
will stay.

-- 
Kind regards,
Luca Boccassi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: This is a digitally signed message part
URL: <http://alioth-lists.debian.net/pipermail/pkg-dpdk-devel/attachments/20200312/45b43b97/attachment.sig>