[Pkg-e-devel] Bug#535768: closed by Albin Tonnerre <lutin at debian.org> (Bug#535768: fixed in evas 0.9.9.49898-1)

Manuel Menal mmenal at hurdfr.org
Wed Jul 28 15:47:23 UTC 2010


reopen 535768
thanks

Hi,

Thanks for fixing the PATH_MAX and fb problems. Unfortunately, evas  
still FTBFS on hurd-i386 because another problem has been introduced  
(use of SA_SIGINFO, which isn't supported by GNU/Hurd). As this  
feature is not used at all anyway, I'm sending a patch that goes back  
to using sa_handler, which works everywhere.

Thanks!


diff -Nurp evas-0.9.9.49898.orig//src/bin/evas_cserve_main.c  
evas-0.9.9.49898/src/bin/evas_cserve_main.c
--- evas-0.9.9.49898.orig//src/bin/evas_cserve_main.c	2010-07-28  
16:54:37.000000000 +0200
+++ evas-0.9.9.49898/src/bin/evas_cserve_main.c	2010-07-28  
16:55:08.000000000 +0200
@@ -1454,13 +1454,13 @@ parse_args(int argc, char **argv)
  static int exit_flag = 0;

  static void
-exit_handler(int x, siginfo_t *info, void *data)
+exit_handler(int x)
  {
     exit_flag = 1;
  }

  static void
-pipe_handler(int x, siginfo_t *info, void *data)
+pipe_handler(int x)
  {
  }

@@ -1469,27 +1469,23 @@ signal_init(void)
  {
     struct sigaction action, old_action;

-   action.sa_handler = NULL;
-   action.sa_sigaction = exit_handler;
-   action.sa_flags = SA_RESTART | SA_SIGINFO;
+   action.sa_handler = exit_handler;
+   action.sa_flags = SA_RESTART;
     sigemptyset(&action.sa_mask);
     sigaction(SIGINT, &action, &old_action);

-   action.sa_handler = NULL;
-   action.sa_sigaction = exit_handler;
-   action.sa_flags = SA_RESTART | SA_SIGINFO;
+   action.sa_handler = exit_handler;
+   action.sa_flags = SA_RESTART;
     sigemptyset(&action.sa_mask);
     sigaction(SIGTERM, &action, &old_action);

-   action.sa_handler = NULL;
-   action.sa_sigaction = exit_handler;
-   action.sa_flags = SA_RESTART | SA_SIGINFO;
+   action.sa_handler = exit_handler;
+   action.sa_flags = SA_RESTART;
     sigemptyset(&action.sa_mask);
     sigaction(SIGQUIT, &action, &old_action);

-   action.sa_handler = NULL;
-   action.sa_sigaction = pipe_handler;
-   action.sa_flags = SA_RESTART | SA_SIGINFO;
+   action.sa_handler = pipe_handler;
+   action.sa_flags = SA_RESTART;
     sigemptyset(&action.sa_mask);
     sigaction(SIGPIPE, &action, &old_action);

diff -Nurp evas-0.9.9.49898.orig//src/lib/cserve/evas_cs_client.c  
evas-0.9.9.49898/src/lib/cserve/evas_cs_client.c
--- evas-0.9.9.49898.orig//src/lib/cserve/evas_cs_client.c	2010-07-28  
16:54:39.000000000 +0200
+++ evas-0.9.9.49898/src/lib/cserve/evas_cs_client.c	2010-07-28  
16:55:08.000000000 +0200
@@ -14,7 +14,7 @@ static int connect_num = 0;
  static int cserve_discon = 0;

  static void
-pipe_handler(int x __UNUSED__, siginfo_t *info __UNUSED__, void *data  
__UNUSED__)
+pipe_handler(int x __UNUSED__)
  {
  }

@@ -26,9 +26,8 @@ pipe_handle(int push)

     if (push)
       {
-        action.sa_handler = NULL;
-        action.sa_sigaction = pipe_handler;
-        action.sa_flags = SA_RESTART | SA_SIGINFO;
+        action.sa_handler = pipe_handler;
+        action.sa_flags = SA_RESTART;
          sigemptyset(&action.sa_mask);
          sigaction(SIGPIPE, &action, &old_action);
       }


-- 
Manuel Menal






More information about the Pkg-e-devel mailing list