[Pkg-e-devel] Bug#696276: e17: Sets FD_CLOEXEC incorrectly with F_SETFL instead of F_SETFD

[Guillem Jover]

Source: e17
Version: 0.16.999.70492-2
Severity: important
Tags: patch
User: debian-bsd at lists.debian.org
Usertags: fcntl-fd-cloexec

Hi!

This package contains code that tries to set the FD_CLOEXEC flag for a
file descriptor, but it does using F_SETFL instead of F_SETFD.

Using that value on F_SETFL is just wrong, and might make the call fail
on some systems, as it's requesting to set an undetermined flag. For
example on GNU/* FD_CLOEXEC has value 1, which matches with O_WRONLY.

This might cause the code to at least leak file descriptors, and at
worst to terminate execution.

Attached a patch fixing this.

Thanks,
Guillem
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-e17-Set-FD_CLOEXEC-correctly-using-F_SETFD-not-F_SET.patch
Type: text/x-diff
Size: 1327 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-e-devel/attachments/20121218/3f3fd451/attachment.patch>