[Pkg-electronics-devel] 'gtkwave' uploaded to mentors.debian.net

[أحمد المحمودي]

On Mon, Jan 04, 2010 at 03:47:52PM +0200, أحمد المحمودي wrote:
> > The upstream source includes its own LibLzma.c which is included
> > regardless of whether you have liblzma installed. They build a static
> > library libgwlzma which is then used by the main program.
> > I can't tell if it duplicates liblzma or not, but it would be bad if it
> > does.
> 
> Actually the source also includes: libz/ libz2/ , but they are not built.
> 
> But I don't understand what liblzma is built (& gtkwave is linked 
> against the liblzma provided with gtkwave source !) even though 
> liblzma-dev is installed !
---end quoted text---

Looking further into the matter, it seems that src/liblzma/LzmaLib.c 
actually uses the installed lzma library, as it has lines such as:

#ifdef _WAVE_HAVE_XZ
#include "lzma.h"
#endif


and there are several of those in that file:

#ifdef _WAVE_HAVE_XZ
...
#endif

also, from the build log, _WAVE_HAVE_XZ is defined:

1) configure script 

  LIBXZ_CFLAGS     : -D_WAVE_HAVE_XZ

2) build in src/liblzma:

make[5]: Entering directory `/tmp/buildd/gtkwave-3.3.0/src/liblzma'
gcc -DHAVE_CONFIG_H -I. -I. -I../..   -DWAVE_USE_GTK2  -D_LARGEFILE64_SOURCE -D_WAVE_HAVE_XZ -g -O2 -c LzmaLib.c

So maybe it isn't an issue after all.

-- 
 ‎أحمد المحمودي (Ahmed El-Mahmoudy)
  Digital design engineer
 GPG KeyID: 0xEDDDA1B7 (@ subkeys.pgp.net)
 GPG Fingerprint: 8206 A196 2084 7E6D 0DF8  B176 BC19 6A94 EDDD A1B7