[Pkg-electronics-devel] Hello list I am Bhavani Shankar and about RFS of emu8051

[أحمد المحمودي]

Hello,

On Sat, Jun 12, 2010 at 10:03:29PM +0530, Bhavani Shankar R wrote:
> I am Bhavani Shankar a 23 year old electrical engineer by profession born
> brought up and settled in Bangalore India and since my area of interest is
> electrical and electronics I would like to join the team to work on
> electronics packages and in this regard I am trying to port emu8051 which is
> a simple 8051 microcontroller emulator from ubuntu and I ve posted a RFS on
> mentors.debian.net which is quoted for your kind perusal here:
---end quoted text---

  Nice having you here ! I am not a DD, but here are my comments:

  * debian/docs: There's no need to install the 'INSTALL' nor README files
    Note that lintian gives this warning:
    W: emu8051: package-contains-upstream-install-documentation usr/share/doc/emu8051/INSTALL.gz

  * debian/copyright: Why are you licensing the packaging work under 
    public domain ? It is better to have the packaging work under the 
    same license of the upstream project, in order to avoid legal issues 
    when you decide to introduce a patch for example to upstream code.

  * debian/control: I'm not sure about your use of 
    XSBC-Original-Maintainer, I've seen your reason in the changelog, I 
    hope someone on the list would comment. Note, that it causes this 
    lintian warning:
    W: emu8051 source: unknown-field-in-dsc original-maintainer

  * I would recommend adding a .desktop file for the emulator, and send 
    it to upstream.
  * I'd recommend using 3.0 (quilt) source format, you won't need to do 
    any change in your package except to modify source/format file


-- 
 ‎أحمد المحمودي (Ahmed El-Mahmoudy)
  Digital design engineer
 GPG KeyID: 0xEDDDA1B7
 GPG Fingerprint: 8206 A196 2084 7E6D 0DF8  B176 BC19 6A94 EDDD A1B7